Changeset 161519 in webkit

Timestamp:

Jan 8, 2014 1:38:42 PM (10 years ago)

Author:

zandobersek@gmail.com

Message:

Unreviewed, rolling out r161517.
​http://trac.webkit.org/changeset/161517
​https://bugs.webkit.org/show_bug.cgi?id=126659

The fix didn't completely remove the problem and is now
standing in the way of the rollout of the offending patch
(Requested by zdobersek on #webkit).

Patch by Commit Queue <​commit-queue@webkit.org> on 2014-01-08

• Scripts/webkitpy/port/gtk.py:

(GtkPort.init):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/gtk.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-01-08  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r161517.
+        http://trac.webkit.org/changeset/161517
+        https://bugs.webkit.org/show_bug.cgi?id=126659
+
+        The fix didn't completely remove the problem and is now
+        standing in the way of the rollout of the offending patch
+        (Requested by zdobersek on #webkit).
+
+        * Scripts/webkitpy/port/gtk.py:
+        (GtkPort.__init__):
+
 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Tools/Scripts/webkitpy/port/gtk.py

@@ -48 +48 @@
         super(GtkPort, self).__init__(*args, **kwargs)
         self._pulseaudio_sanitizer = PulseAudioSanitizer()
-
-        if self.get_option("leaks"):
-            self._leakdetector = LeakDetectorValgrind(self._filesystem, self.results_directory())
+        self._leakdetector = LeakDetectorValgrind(self._filesystem, self.results_directory())
+
+        if self.get_option("leaks"):
             if not self.get_option("wrapper"):
                 raise ValueError('use --wrapper=\"valgrind\" for memory leak detection on GTK')