Changeset 161520 in webkit


Ignore:
Timestamp:
Jan 8, 2014 1:45:36 PM (10 years ago)
Author:
zandobersek@gmail.com
Message:

Unreviewed, rolling out r161512.
http://trac.webkit.org/changeset/161512
https://bugs.webkit.org/show_bug.cgi?id=126655

Broke webkitpy tests (Requested by ap on #webkit).

Patch by Commit Queue <commit-queue@webkit.org> on 2014-01-08

  • Scripts/webkitpy/port/gtk.py:

(GtkPort.init):
(GtkPort.setup_test_run):
(GtkPort._port_specific_expectations_files):

  • Scripts/webkitpy/port/leakdetector_valgrind.py: Removed.
  • Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Removed.
Location:
trunk/Tools
Files:
2 deleted
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r161519 r161520  
     12014-01-08  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r161512.
     4        http://trac.webkit.org/changeset/161512
     5        https://bugs.webkit.org/show_bug.cgi?id=126655
     6
     7        Broke webkitpy tests (Requested by ap on #webkit).
     8
     9        * Scripts/webkitpy/port/gtk.py:
     10        (GtkPort.__init__):
     11        (GtkPort.setup_test_run):
     12        (GtkPort._port_specific_expectations_files):
     13        * Scripts/webkitpy/port/leakdetector_valgrind.py: Removed.
     14        * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Removed.
     15
    1162014-01-08  Commit Queue  <commit-queue@webkit.org>
    217
  • trunk/Tools/Scripts/webkitpy/port/gtk.py

    r161519 r161520  
    3939from webkitpy.port.westondriver import WestonDriver
    4040from webkitpy.port.linux_get_crash_log import GDBCrashLogGenerator
    41 from webkitpy.port.leakdetector_valgrind import LeakDetectorValgrind
    4241
    4342
     
    4847        super(GtkPort, self).__init__(*args, **kwargs)
    4948        self._pulseaudio_sanitizer = PulseAudioSanitizer()
    50         self._leakdetector = LeakDetectorValgrind(self._filesystem, self.results_directory())
    5149
    5250        if self.get_option("leaks"):
     
    8381        super(GtkPort, self).setup_test_run()
    8482        self._pulseaudio_sanitizer.unload_pulseaudio_module()
    85 
    86         if self.get_option("leaks"):
    87             self._leakdetector.clean_leaks_files_from_results_directory()
    8883
    8984    def clean_up_test_run(self):
     
    165160        return [self._filesystem.join(self._webkit_baseline_path(p), 'TestExpectations') for p in reversed(self._search_paths())]
    166161
    167     def print_leaks_summary(self):
    168         if not self.get_option('leaks'):
    169             return
    170         # FIXME: This is a hack, but we don't have a better way to get this information from the workers yet
    171         # because we're in the manager process.
    172         leaks_files = self._leakdetector.leaks_files_in_results_directory()
    173         if not leaks_files:
    174             return
    175         self._leakdetector.parse_and_print_leaks_detail(leaks_files)
    176 
    177162    # FIXME: We should find a way to share this implmentation with Gtk,
    178163    # or teach run-launcher how to call run-safari and move this down to Port.
Note: See TracChangeset for help on using the changeset viewer.