Changeset 161673 in webkit

Timestamp:

Jan 10, 2014 1:42:07 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

[CSS Blending] Log blending as a layer creation reason in the WI
​https://bugs.webkit.org/show_bug.cgi?id=126159

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-10
Reviewed by Timothy Hatcher.

Source/WebCore:

• inspector/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):

• inspector/protocol/LayerTree.json:

Source/WebInspectorUI:

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/LayerTreeSidebarPanel.js:

(WebInspector.LayerTreeSidebarPanel.prototype._populateListOfCompositingReasons):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/inspector/InspectorLayerTreeAgent.cpp (modified) (1 diff)
• WebCore/inspector/protocol/LayerTree.json (modified) (1 diff)
• WebInspectorUI/ChangeLog (modified) (1 diff)
• WebInspectorUI/Localizations/en.lproj/localizedStrings.js (modified) (1 diff)
• WebInspectorUI/UserInterface/LayerTreeSidebarPanel.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-01-10  Joseph Pecoraro  <pecoraro@apple.com>
+
+        [CSS Blending] Log blending as a layer creation reason in the WI
+        https://bugs.webkit.org/show_bug.cgi?id=126159
+
+        Reviewed by Timothy Hatcher.
+
+        * inspector/InspectorLayerTreeAgent.cpp:
+        (WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):
+        * inspector/protocol/LayerTree.json:
+
 2014-01-10  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebCore/inspector/InspectorLayerTreeAgent.cpp

@@ -308 +308 @@
     if (reasonsBitmask & CompositingReasonRoot)
         compositingReasons->setRoot(true);
+
+    if (reasonsBitmask & CompositingReasonBlending)
+        compositingReasons->setBlending(true);
 }
 

trunk/Source/WebCore/inspector/protocol/LayerTree.json

@@ -70 +70 @@
                 { "name": "perspective", "type": "boolean", "optional": true, "description": "Composition due to association with an element with perspective applied." },
                 { "name": "preserve3D", "type": "boolean", "optional": true, "description": "Composition due to association with an element with a \"transform-style: preserve-3d\" style." },
-                { "name": "root", "type": "boolean", "optional": true, "description": "Composition due to association with the root element." }
+                { "name": "root", "type": "boolean", "optional": true, "description": "Composition due to association with the root element." },
+                { "name": "blending", "type": "boolean", "optional": true, "description": "Composition due to association with an element with a \"blend-mode\" style." }
             ]
         }

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2014-01-10  Joseph Pecoraro  <pecoraro@apple.com>
+
+        [CSS Blending] Log blending as a layer creation reason in the WI
+        https://bugs.webkit.org/show_bug.cgi?id=126159
+
+        Reviewed by Timothy Hatcher.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        * UserInterface/LayerTreeSidebarPanel.js:
+        (WebInspector.LayerTreeSidebarPanel.prototype._populateListOfCompositingReasons):
+
 2014-01-10  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
 

trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

@@ -150 +150 @@
 localizedStrings["Element has “-webkit-overflow-scrolling: touch” style"] = "Element has “-webkit-overflow-scrolling: touch” style";
 localizedStrings["Element has “backface-visibility: hidden” style"] = "Element has “backface-visibility: hidden” style";
+localizedStrings["Element has “blend-mode” style"] = "Element has “blend-mode” style";
 localizedStrings["Element has “position: fixed” style"] = "Element has “position: fixed” style";
 localizedStrings["Element has “position: sticky” style"] = "Element has “position: sticky” style";

trunk/Source/WebInspectorUI/UserInterface/LayerTreeSidebarPanel.js

@@ -429 +429 @@
         if (compositingReasons.root)
             addReason(WebInspector.UIString("Element is the root element"));
+        if (compositingReasons.blending)
+            addReason(WebInspector.UIString("Element has “blend-mode” style"));
     }
 };