Changeset 161789 in webkit
- Timestamp:
- Jan 11, 2014 6:51:19 PM (10 years ago)
- Location:
- trunk
- Files:
-
- 3 added
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r161722 r161789 1 2014-01-11 Dean Jackson <dino@apple.com> 2 3 [JSC] Revise typed array implementations to match ECMAScript and WebGL Specification 4 https://bugs.webkit.org/show_bug.cgi?id=126754 5 6 Reviewed by Filip Pizlo. 7 8 New test which checks that we throw an exception when calling 9 any of the typed array constructors without using "new". 10 11 * js/script-tests/typedarray-constructors.js: Added. 12 * js/typedarray-constructors-expected.txt: Added. 13 * js/typedarray-constructors.html: Added. 14 * resources/standalone-pre.js: Add missing 'shouldNotThrow' 15 method (duplicated from resources/js-test-pre.js) 16 1 17 2014-01-10 Commit Queue <commit-queue@webkit.org> 2 18 -
trunk/LayoutTests/fast/canvas/webgl/data-view-test-expected.txt
r154132 r161789 5 5 6 6 Test for constructor not called as a function 7 FAIL DataView(new ArrayBuffer) does not throw exception7 PASS DataView(new ArrayBuffer) threw exception 8 8 9 9 Test for constructor taking 1 argument -
trunk/LayoutTests/resources/standalone-pre.js
r155250 r161789 207 207 } 208 208 209 function shouldNotThrow(_a) { 210 try { 211 eval(_a); 212 testPassed(_a + " did not throw exception."); 213 } catch (e) { 214 testFailed(_a + " should not throw exception. Threw exception " + e + "."); 215 } 216 } 209 217 210 218 function shouldThrow(_a, _e) -
trunk/Source/JavaScriptCore/ChangeLog
r161788 r161789 1 2014-01-11 Dean Jackson <dino@apple.com> 2 3 [JSC] Revise typed array implementations to match ECMAScript and WebGL Specification 4 https://bugs.webkit.org/show_bug.cgi?id=126754 5 6 Reviewed by Filip Pizlo. 7 8 The ECMAScript specification forbids calling the typed array 9 constructors without using "new". Change the call data to return 10 none so we throw and exception in these cases. 11 12 * runtime/JSGenericTypedArrayViewConstructorInlines.h: 13 (JSC::JSGenericTypedArrayViewConstructor<ViewClass>::getCallData): 14 1 15 2014-01-11 Anders Carlsson <andersca@apple.com> 2 16 -
trunk/Source/JavaScriptCore/runtime/JSGenericTypedArrayViewConstructorInlines.h
r161722 r161789 158 158 { 159 159 callData.native.function = constructGenericTypedArrayView<ViewClass>; 160 return CallType Host;160 return CallTypeNone; 161 161 } 162 162
Note: See TracChangeset
for help on using the changeset viewer.