Changeset 161804 in webkit

Timestamp:

Jan 11, 2014, 11:31:52 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Support bool argument for encoding/decoding invocations.
​https://bugs.webkit.org/show_bug.cgi?id=126823

Patch by Yongjun Zhang <​yongjun_zhang@apple.com> on 2014-01-11
Reviewed by Sam Weinig.

For remote invocation method argument, current we support int, double and ObjC
object, this patch add support for bool type too.

• Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(encodeInvocation):
(decodeInvocationArguments):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/API/Cocoa/WKRemoteObjectCoder.mm (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-01-11  Yongjun Zhang  <yongjun_zhang@apple.com>
+
+        Support bool argument for encoding/decoding invocations.
+        https://bugs.webkit.org/show_bug.cgi?id=126823
+
+        Reviewed by Sam Weinig.
+
+        For remote invocation method argument, current we support int, double and ObjC
+        object, this patch add support for bool type too.
+
+        * Shared/API/Cocoa/WKRemoteObjectCoder.mm:
+        (encodeInvocation):
+        (decodeInvocationArguments):
+
 2014-01-11  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm

@@ -147 +147 @@
         }
 
+        // bool
+        case 'B': {
+            BOOL value;
+            [invocation getArgument:&value atIndex:i];;
+
+            encodeToObjectStream(encoder, @(value));
+            break;
+        }
+
         // Objective-C object
         case '@': {
@@ -386 +395 @@
         }
 
+        // bool
+        case 'B': {
+            bool value = [decodeObjectFromObjectStream(decoder, [NSSet setWithObject:[NSNumber class]]) boolValue];
+            [invocation setArgument:&value atIndex:i];
+            break;
+        }
+
         // Objective-C object
         case '@': {