Changeset 161903 in webkit

Timestamp:

Jan 13, 2014 12:56:04 PM (10 years ago)

Author:

dbates@webkit.org

Message:

Add uint8_t specialization for WebCore::writeLittleEndian()
​https://bugs.webkit.org/show_bug.cgi?id=126924

Reviewed by Darin Adler.

Specialize WebCore::writeLittleEndian() for datatype uint8_t so as to avoid
a compiler warning when right shifting a uint8_t by 8 because the result of
such a computation is undefined.

• bindings/js/SerializedScriptValue.cpp:

(WebCore::writeLittleEndian<uint8_t>): Added.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/js/SerializedScriptValue.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-01-13  Daniel Bates  <dabates@apple.com>
+
+        Add uint8_t specialization for WebCore::writeLittleEndian()
+        https://bugs.webkit.org/show_bug.cgi?id=126924
+
+        Reviewed by Darin Adler.
+
+        Specialize WebCore::writeLittleEndian() for datatype uint8_t so as to avoid
+        a compiler warning when right shifting a uint8_t by 8 because the result of
+        such a computation is undefined.
+
+        * bindings/js/SerializedScriptValue.cpp:
+        (WebCore::writeLittleEndian<uint8_t>): Added.
+
 2014-01-13  Daniel Bates  <dabates@apple.com>
 

trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp

@@ -426 +426 @@
 }
 
+template <> bool writeLittleEndian<uint8_t>(Vector<uint8_t>& buffer, const uint8_t* values, uint32_t length)
+{
+    buffer.append(values, length);
+    return true;
+}
+
 class CloneSerializer : CloneBase {
 public: