Changeset 162028 in webkit

Timestamp:

Jan 14, 2014 5:35:27 PM (10 years ago)

Author:

benjamin@webkit.org

Message:

[WK2] Make WebPageProxy's setUserAgent private
​https://bugs.webkit.org/show_bug.cgi?id=127013

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-01-14
Reviewed by Anders Carlsson.

• UIProcess/WebPageProxy.h:

The API to modify the user agent already has 3 "setters":
-standardUserAgent
-setApplicationNameForUserAgent
-setCustomUserAgent

The method WebPageProxy::setUserAgent() is supposed to be internal, not used directly.
Using it directly would cause unexpected behaviors, for example:
-Set the user agent with setUserAgent.
-Set CustomUserAgent.
-Reset CustomUserAgent.
->The user agent is now standardUserAgent instead of the user agent defined initially.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageProxy.h (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-01-14  Benjamin Poulain  <bpoulain@apple.com>
+
+        [WK2] Make WebPageProxy's setUserAgent private
+        https://bugs.webkit.org/show_bug.cgi?id=127013
+
+        Reviewed by Anders Carlsson.
+
+        * UIProcess/WebPageProxy.h:
+        The API to modify the user agent already has 3 "setters":
+        -standardUserAgent
+        -setApplicationNameForUserAgent
+        -setCustomUserAgent
+
+        The method WebPageProxy::setUserAgent() is supposed to be internal, not used directly.
+        Using it directly would cause unexpected behaviors, for example:
+        -Set the user agent with setUserAgent.
+        -Set CustomUserAgent.
+        -Reset CustomUserAgent.
+        ->The user agent is now standardUserAgent instead of the user agent defined initially.
+
 2014-01-14  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebKit2/UIProcess/WebPageProxy.h

@@ -523 +523 @@
     const String& toolTip() const { return m_toolTip; }
 
-    void setUserAgent(const String&);
     const String& userAgent() const { return m_userAgent; }
     void setApplicationNameForUserAgent(const String&);
@@ -864 +863 @@
     void resetState();
     void resetStateAfterProcessExited();
+
+    void setUserAgent(const String&);
 
     // IPC::MessageReceiver