Changeset 162136 in webkit

Timestamp:

Jan 16, 2014 11:06:41 AM (10 years ago)

Author:

BJ Burg

Message:

Web Inspector: add probe breakpoint action to popup breakpoint editor
​https://bugs.webkit.org/show_bug.cgi?id=126931

Reviewed by Timothy Hatcher.

Add probes to the breakpoint action dropdown.
Reuse the "evaluate JavaScript" input UI.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/BreakpointAction.js:
• UserInterface/BreakpointActionView.js:

(WebInspector.BreakpointActionView.displayStringForType):
(WebInspector.BreakpointActionView.prototype._updateBody.switch.break):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• Localizations/en.lproj/localizedStrings.js (modified) (1 diff)
• UserInterface/BreakpointAction.js (modified) (1 diff)
• UserInterface/BreakpointActionView.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2014-01-16  Brian Burg  <bburg@apple.com>
+
+        Web Inspector: add probe breakpoint action to popup breakpoint editor
+        https://bugs.webkit.org/show_bug.cgi?id=126931
+
+        Reviewed by Timothy Hatcher.
+
+        Add probes to the breakpoint action dropdown.
+        Reuse the "evaluate JavaScript" input UI.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        * UserInterface/BreakpointAction.js:
+        * UserInterface/BreakpointActionView.js:
+        (WebInspector.BreakpointActionView.displayStringForType):
+        (WebInspector.BreakpointActionView.prototype._updateBody.switch.break):
+
 2014-01-15  Brian Burg  <bburg@apple.com>
 

trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

@@ -289 +289 @@
 localizedStrings["Port"] = "Port";
 localizedStrings["Pretty print"] = "Pretty print";
+localizedStrings["Probe Expression"] = "Probe Expression";
 localizedStrings["Processing Instruction"] = "Processing Instruction";
 localizedStrings["Profile %d"] = "Profile %d";

trunk/Source/WebInspectorUI/UserInterface/BreakpointAction.js

@@ -48 +48 @@
     Log: "log",
     Evaluate: "evaluate",
-    Sound: "sound"
+    Sound: "sound",
+    Probe: "probe"
 }
 

trunk/Source/WebInspectorUI/UserInterface/BreakpointActionView.js

@@ -78 +78 @@
     case WebInspector.BreakpointAction.Type.Sound:
         return WebInspector.UIString("Play Sound");
+    case WebInspector.BreakpointAction.Type.Probe:
+        return WebInspector.UIString("Probe Expression");
     default:
         console.assert(false);
@@ -140 +142 @@
 
         case WebInspector.BreakpointAction.Type.Evaluate:
+        case WebInspector.BreakpointAction.Type.Probe:
             this._bodyElement.hidden = false;