Changeset 162182 in webkit

Timestamp:

Jan 16, 2014 9:27:13 PM (10 years ago)

Author:

eunmi15.lee@samsung.com

Message:

[EFL][WK2] EwkView can not be shown without re-sizing once it is hidden.
​https://bugs.webkit.org/show_bug.cgi?id=127084

Reviewed by Gyuyoung Kim.

Visibility of EwkView can not be controlled by evas_object_show/hide
because EwkView can be shown only if re-sizing is requested, so modify
codes to show EwkView directly if we do not wait for re-sizing.
Additionally, we have to set default value of m_pendingSurfaceResize
to true for accelerated mode to prevent to show black empty view for
the first request to show.

• UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::handleEvasObjectShow):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/efl/EwkView.cpp (modified) (3 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-01-16  Eunmi Lee  <eunmi15.lee@samsung.com>
+
+        [EFL][WK2] EwkView can not be shown without re-sizing once it is hidden.
+        https://bugs.webkit.org/show_bug.cgi?id=127084
+
+        Reviewed by Gyuyoung Kim.
+
+        Visibility of EwkView can not be controlled by evas_object_show/hide
+        because EwkView can be shown only if re-sizing is requested, so modify
+        codes to show EwkView directly if we do not wait for re-sizing.
+        Additionally, we have to set default value of m_pendingSurfaceResize
+        to true for accelerated mode to prevent to show black empty view for
+        the first request to show.
+
+        * UIProcess/API/efl/EwkView.cpp:
+        (EwkView::EwkView):
+        (EwkView::handleEvasObjectShow):
+
 2014-01-16  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/efl/EwkView.cpp

@@ -257 +257 @@
     , m_context(EwkContext::findOrCreateWrapper(WKPageGetContext(wkPage())))
     , m_pageGroup(EwkPageGroup::findOrCreateWrapper(WKPageGetPageGroup(wkPage())))
-#if USE(ACCELERATED_COMPOSITING)
-    , m_pendingSurfaceResize(false)
-#endif
     , m_pageLoadClient(std::make_unique<PageLoadClientEfl>(this))
     , m_pagePolicyClient(std::make_unique<PagePolicyClientEfl>(this))
@@ -301 +298 @@
         m_isAccelerated = false;
     }
+
+    m_pendingSurfaceResize = m_isAccelerated;
 #endif
     WKViewInitialize(wkView());
@@ -1219 +1218 @@
     ASSERT(smartData);
 
-    if (!toEwkView(smartData)->m_isAccelerated)
+#if USE(ACCELERATED_COMPOSITING)
+    if (!toEwkView(smartData)->m_pendingSurfaceResize)
+#endif
         showEvasObjectsIfNeeded(smartData);
 }