Changeset 162215 in webkit

Timestamp:

Jan 17, 2014 12:56:01 PM (10 years ago)

Author:

Manuel Rego Casasnovas

Message:

[GTK] Add CSS Grid Layout as experimental feature
​https://bugs.webkit.org/show_bug.cgi?id=127089

Reviewed by Martin Robinson.

Allow CSS Grid Layout to be enabled through the environment variable WEBKITGTK_EXPERIMENTAL_FEATURES.

Example: WEBKITGTK_EXPERIMENTAL_FEATURES="CSS_GRID_LAYOUT=1"

• UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsConstructed): Use new experimental feature to enable or disable CSS Grid Layout.

• UIProcess/gtk/ExperimentalFeatures.cpp: Add new experimental feature.
• UIProcess/gtk/ExperimentalFeatures.h: Ditto.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/gtk/WebKitSettings.cpp (modified) (1 diff)
• UIProcess/gtk/ExperimentalFeatures.cpp (modified) (1 diff)
• UIProcess/gtk/ExperimentalFeatures.h (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-01-17  Manuel Rego Casasnovas  <rego@igalia.com>
+
+        [GTK] Add CSS Grid Layout as experimental feature
+        https://bugs.webkit.org/show_bug.cgi?id=127089
+
+        Reviewed by Martin Robinson.
+
+        Allow CSS Grid Layout to be enabled through the environment variable WEBKITGTK_EXPERIMENTAL_FEATURES.
+
+        Example: WEBKITGTK_EXPERIMENTAL_FEATURES="CSS_GRID_LAYOUT=1"
+
+        * UIProcess/API/gtk/WebKitSettings.cpp:
+        (webKitSettingsConstructed): Use new experimental feature to enable or disable CSS Grid Layout.
+        * UIProcess/gtk/ExperimentalFeatures.cpp: Add new experimental feature.
+        * UIProcess/gtk/ExperimentalFeatures.h: Ditto.
+
 2014-01-17  Enrica Casucci  <enrica@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp

@@ -148 +148 @@
     WebPreferences* prefs = WEBKIT_SETTINGS(object)->priv->preferences.get();
     ExperimentalFeatures features;
+    bool cssGridLayoutEnabled = features.isEnabled(ExperimentalFeatures::CSSGridLayout);
+    if (prefs->cssGridLayoutEnabled() != cssGridLayoutEnabled)
+        prefs->setCSSGridLayoutEnabled(cssGridLayoutEnabled);
     bool regionBasedColumnsEnabled = features.isEnabled(ExperimentalFeatures::RegionBasedColumns);
     if (prefs->regionBasedColumnsEnabled() != regionBasedColumnsEnabled)

trunk/Source/WebKit2/UIProcess/gtk/ExperimentalFeatures.cpp

@@ -40 +40 @@
 
 static Setting settings[] = {
+    { ExperimentalFeatures::CSSGridLayout, "CSS_GRID_LAYOUT", false },
     { ExperimentalFeatures::RegionBasedColumns, "REGION_BASED_COLUMNS", false }
 };

trunk/Source/WebKit2/UIProcess/gtk/ExperimentalFeatures.h

@@ -38 +38 @@
 public:
     enum Feature {
+        CSSGridLayout,
         RegionBasedColumns
     };