Changeset 162281 in webkit

Timestamp:

Jan 18, 2014 3:35:34 PM (10 years ago)

Author:

akling@apple.com

Message:

CodeBlock: Size m_function{Exprs,Decls} to fit from creation.
<​https://webkit.org/b/127238>

Reviewed by Anders Carlsson.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

Use resizeToFit() instead of grow() for m_functionExprs and
m_functionDecls since we know they will never change size.

(JSC::CodeBlock::shrinkToFit):

No need to shrink them here anymore.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• bytecode/CodeBlock.cpp (modified) (3 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2014-01-18  Andreas Kling  <akling@apple.com>
+
+        CodeBlock: Size m_function{Exprs,Decls} to fit from creation.
+        <https://webkit.org/b/127238>
+
+        Reviewed by Anders Carlsson.
+
+        * bytecode/CodeBlock.cpp:
+        (JSC::CodeBlock::CodeBlock):
+
+            Use resizeToFit() instead of grow() for m_functionExprs and
+            m_functionDecls since we know they will never change size.
+
+        (JSC::CodeBlock::shrinkToFit):
+
+            No need to shrink them here anymore.
+
 2014-01-18  Andreas Kling  <akling@apple.com>
 

trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp

@@ -1559 +1559 @@
     if (unlinkedCodeBlock->usesGlobalObject())
         m_constantRegisters[unlinkedCodeBlock->globalObjectRegister().offset()].set(*m_vm, ownerExecutable, m_globalObject.get());
-    m_functionDecls.grow(unlinkedCodeBlock->numberOfFunctionDecls());
+    m_functionDecls.resizeToFit(unlinkedCodeBlock->numberOfFunctionDecls());
     for (size_t count = unlinkedCodeBlock->numberOfFunctionDecls(), i = 0; i < count; ++i) {
         UnlinkedFunctionExecutable* unlinkedExecutable = unlinkedCodeBlock->functionDecl(i);
@@ -1575 +1575 @@
     }
 
-    m_functionExprs.grow(unlinkedCodeBlock->numberOfFunctionExprs());
+    m_functionExprs.resizeToFit(unlinkedCodeBlock->numberOfFunctionExprs());
     for (size_t count = unlinkedCodeBlock->numberOfFunctionExprs(), i = 0; i < count; ++i) {
         UnlinkedFunctionExecutable* unlinkedExecutable = unlinkedCodeBlock->functionExpr(i);
@@ -2591 +2591 @@
     
     if (shrinkMode == EarlyShrink) {
-        m_functionDecls.shrinkToFit();
-        m_functionExprs.shrinkToFit();
         m_constantRegisters.shrinkToFit();