Changeset 162443 in webkit

Timestamp:

Jan 21, 2014, 8:40:38 AM (12 years ago)

Author:

Antti Koivisto

Message:

Delay initial layer flush during loading on all platforms
​https://bugs.webkit.org/show_bug.cgi?id=127347

Reviewed by Andreas Kling.

To reduce unnecessary repaints enable the same behaviour as iOS already has.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::RenderLayerCompositor):

Set the initial state of m_layerFlushThrottlingEnabled correctly.

(WebCore::RenderLayerCompositor::scheduleLayerFlush):
(WebCore::RenderLayerCompositor::startInitialLayerFlushTimerIfNeeded):

• rendering/RenderLayerCompositor.h:

Enable initial layer flush delay on all platforms.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderLayerCompositor.cpp (modified) (6 diffs)
• rendering/RenderLayerCompositor.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-01-21  Antti Koivisto  <antti@apple.com>
+
+        Delay initial layer flush during loading on all platforms
+        https://bugs.webkit.org/show_bug.cgi?id=127347
+
+        Reviewed by Andreas Kling.
+
+        To reduce unnecessary repaints enable the same behaviour as iOS already has.
+
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::RenderLayerCompositor::RenderLayerCompositor):
+        
+            Set the initial state of m_layerFlushThrottlingEnabled correctly.
+
+        (WebCore::RenderLayerCompositor::scheduleLayerFlush):
+        (WebCore::RenderLayerCompositor::startInitialLayerFlushTimerIfNeeded):
+        * rendering/RenderLayerCompositor.h:
+        
+            Enable initial layer flush delay on all platforms.
+
 2014-01-21  Mihai Tica  <mitica@adobe.com>
 

trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp

@@ -46 +46 @@
 #include "NodeList.h"
 #include "Page.h"
+#include "ProgressTracker.h"
 #include "RenderEmbeddedObject.h"
 #include "RenderFlowThread.h"
@@ -99 +100 @@
 static const double throttledLayerFlushDelay = 1.5;
 #else
+static const double throttledLayerFlushInitialDelay = .5;
 static const double throttledLayerFlushDelay = .5;
 #endif
@@ -249 +251 @@
     , m_rootLayerAttachment(RootLayerUnattached)
     , m_layerFlushTimer(this, &RenderLayerCompositor::layerFlushTimerFired)
-    , m_layerFlushThrottlingEnabled(false)
+    , m_layerFlushThrottlingEnabled(page() && page()->progress().isMainLoadProgressing())
     , m_layerFlushThrottlingTemporarilyDisabledForInteraction(false)
     , m_hasPendingLayerFlush(false)
@@ -375 +377 @@
     ASSERT(!m_flushingLayers);
 
-#if PLATFORM(IOS)
     if (canThrottle)
         startInitialLayerFlushTimerIfNeeded();
-#endif
 
     if (canThrottle && isThrottlingLayerFlushes()) {
@@ -3678 +3678 @@
 }
 
-#if PLATFORM(IOS)
 void RenderLayerCompositor::startInitialLayerFlushTimerIfNeeded()
 {
@@ -3687 +3686 @@
     m_layerFlushTimer.startOneShot(throttledLayerFlushInitialDelay);
 }
-#endif
 
 void RenderLayerCompositor::layerFlushTimerFired(Timer<RenderLayerCompositor>&)

trunk/Source/WebCore/rendering/RenderLayerCompositor.h

@@ -407 +407 @@
     ChromeClient* chromeClient() const;
 
-    void startInitialLayerFlushTimerIfNeeded();
 #endif
 
@@ -431 +430 @@
     void scheduleLayerFlushNow();
     bool isThrottlingLayerFlushes() const;
+    void startInitialLayerFlushTimerIfNeeded();
     void startLayerFlushTimerIfNeeded();
     void layerFlushTimerFired(Timer<RenderLayerCompositor>&);