Changeset 162461 in webkit

Timestamp:

Jan 21, 2014 12:25:46 PM (10 years ago)

Author:

Simon Fraser

Message:

Log an error for a common cause of WebProcess early launch crashing in misconfigured development builds
​https://bugs.webkit.org/show_bug.cgi?id=127121

Reviewed by Anders Carlsson.

A common cause of early WebProcess crashes during development is a null return
from CFBundleGetValueForInfoDictionaryKey(), so log and return an error in
this case rather than passing a null C string to dlsym().

• Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.mm:

(WebKit::BootstrapMain):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-01-16  Simon Fraser  <simon.fraser@apple.com>
+
+        Log an error for a common cause of WebProcess early launch crashing in misconfigured development builds
+        https://bugs.webkit.org/show_bug.cgi?id=127121
+
+        Reviewed by Anders Carlsson.
+        
+        A common cause of early WebProcess crashes during development is a null return
+        from CFBundleGetValueForInfoDictionaryKey(), so log and return an error in
+        this case rather than passing a null C string to dlsym().
+
+        * Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.mm:
+        (WebKit::BootstrapMain):
+
 2014-01-21  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebKit2/Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.mm

@@ -67 +67 @@
     @autoreleasepool {
         NSString *entryPointFunctionName = (NSString *)CFBundleGetValueForInfoDictionaryKey(CFBundleGetMainBundle(), CFSTR("WebKitEntryPoint"));
+        if (![entryPointFunctionName length]) {
+            NSLog(@"Failed to get value for \"WebKitEntryPoint\" from bundle dictionary %@", CFBundleGetLocalInfoDictionary(CFBundleGetMainBundle()));
+            return EXIT_FAILURE;
+        }
+
         bootstrapMainFunction = reinterpret_cast<BootstrapMainFunction>(dlsym(frameworkLibrary, [entryPointFunctionName UTF8String]));
         if (!bootstrapMainFunction) {