Changeset 162528 in webkit

Timestamp:

Jan 22, 2014 9:54:32 AM (10 years ago)

Author:

timothy@apple.com

Message:

Remember the Timeline Overview zoom and selection between sessions.

​https://bugs.webkit.org/show_bug.cgi?id=127369

Reviewed by Joseph Pecoraro.

• UserInterface/TimelineOverview.js:

(WebInspector.TimelineOverview):
(WebInspector.TimelineOverview.prototype.set secondsPerPixel):
(WebInspector.TimelineOverview.prototype._timeRangeSelectionChanged):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/TimelineOverview.js (modified) (3 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2014-01-21  Timothy Hatcher  <timothy@apple.com>
+
+        Remember the Timeline Overview zoom and selection between sessions.
+
+        https://bugs.webkit.org/show_bug.cgi?id=127369
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/TimelineOverview.js:
+        (WebInspector.TimelineOverview):
+        (WebInspector.TimelineOverview.prototype.set secondsPerPixel):
+        (WebInspector.TimelineOverview.prototype._timeRangeSelectionChanged):
+
 2014-01-21  Timothy Hatcher  <timothy@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/TimelineOverview.js

@@ -59 +59 @@
     this._scrollContainer.appendChild(this._scrollWidthSizer);
 
+    this._secondsPerPixelSetting = new WebInspector.Setting("timeline-overview-seconds-per-pixel", 0.01);
+    this._selectionStartTimeSetting = new WebInspector.Setting("timeline-overview-selection-start-time", 0);
+    this._selectionDurationSetting = new WebInspector.Setting("timeline-overview-selection-duration", 5);
+
     this._startTime = 0;
     this._currentTime = 0;
     this._endTime = 0;
-    this._secondsPerPixel = 0.0025;
+    this._secondsPerPixel = this._secondsPerPixelSetting.value;
     this._scrollStartTime = 0;
 
-    this.selectionStartTime = 0;
-    this.selectionDuration = 3;
+    this.selectionStartTime = this._selectionStartTimeSetting.value;
+    this.selectionDuration = this._selectionDurationSetting.value;
 };
 
@@ -135 +139 @@
 
         this._secondsPerPixel = x;
+        this._secondsPerPixelSetting.value = x;
 
         this._needsLayout();
@@ -334 +339 @@
     _timeRangeSelectionChanged: function(event)
     {
+        this._selectionStartTimeSetting.value = this.selectionStartTime - this._startTime;
+        this._selectionDurationSetting.value = this.selectionDuration;
+
         this.dispatchEventToListeners(WebInspector.TimelineOverview.Event.TimeRangeSelectionChanged);
     }