Changeset 162587 in webkit

Timestamp:

Jan 22, 2014 8:12:53 PM (10 years ago)

Author:

Samuel White

Message:

AX: Can't always increment web sliders.
​https://bugs.webkit.org/show_bug.cgi?id=127451

Reviewed by Chris Fleizach.

Source/WebCore:

Clamping the decrement/increment amount to one when necessary (if a percent change would result in a change of less than one).

Test: accessibility/range-alter-by-percent.html

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::changeValueByPercent):

LayoutTests:

Adding range-alter-by-percent.html to compliment the existing range-alter-by-step.html test.

• accessibility/range-alter-by-percent-expected.txt: Added.
• accessibility/range-alter-by-percent.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/range-alter-by-percent-expected.txt (added)
• LayoutTests/accessibility/range-alter-by-percent.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AccessibilityNodeObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-01-22  Samuel White  <samuel_white@apple.com>
+
+        AX: Can't always increment web sliders.
+        https://bugs.webkit.org/show_bug.cgi?id=127451
+
+        Reviewed by Chris Fleizach.
+
+        Adding range-alter-by-percent.html to compliment the existing range-alter-by-step.html test.
+
+        * accessibility/range-alter-by-percent-expected.txt: Added.
+        * accessibility/range-alter-by-percent.html: Added.
+
 2014-01-22  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-01-22  Samuel White  <samuel_white@apple.com>
+
+        AX: Can't always increment web sliders.
+        https://bugs.webkit.org/show_bug.cgi?id=127451
+
+        Reviewed by Chris Fleizach.
+
+        Clamping the decrement/increment amount to one when necessary (if a percent change would result in a change of less than one).
+
+        Test: accessibility/range-alter-by-percent.html
+
+        * accessibility/AccessibilityNodeObject.cpp:
+        (WebCore::AccessibilityNodeObject::changeValueByPercent):
+
 2014-01-22  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp

@@ -1097 +1097 @@
 {
     float range = maxValueForRange() - minValueForRange();
+    float step = range * (percentChange / 100);
     float value = valueForRange();
 
-    value += range * (percentChange / 100);
+    // Make sure the specified percent will cause a change of one integer step or larger.
+    if (fabs(step) < 1)
+        step = fabs(percentChange) * (1 / percentChange);
+
+    value += step;
     setValue(String::number(value));