Changeset 162724 in webkit

Timestamp:

Jan 24, 2014 2:05:22 PM (10 years ago)

Author:

vjaquez@igalia.com

Message:

[GTK] youtube HTML5 videos in fullscreen, after <Esc>, can't go fullscreen again
​https://bugs.webkit.org/show_bug.cgi?id=127064

When pressing <Esc> or <f> at full screen, the WebView shall emit the
event webkitfullscreenchange, but wk2gtk does not emit it. This is
because the WebView manages directly the exit of the full screen.

With this patch the WebView calls requestExitFullScreen to the full
screen manager, instead of managing directly the exit of the full
screen, and the event webkitfullscreenchange will be dispatched
correctly.

Reviewed by Martin Robinson.

No tests are included because there is a bug in WKTR that prevents the
execution of a test for this patch. See
​https://bugs.webkit.org/show_bug.cgi?id=127348

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseKeyPressEvent): Call
webkitWebViewBaseRequestExitFullScreen.
(webkitWebViewBaseRequestExitFullScreen): Added.

• UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Ditto.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/gtk/WebKitWebViewBase.cpp (modified) (2 diffs)
• UIProcess/API/gtk/WebKitWebViewBasePrivate.h (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-01-24  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
+
+        [GTK] youtube HTML5 videos in fullscreen, after <Esc>, can't go fullscreen again
+        https://bugs.webkit.org/show_bug.cgi?id=127064
+
+        When pressing <Esc> or <f> at full screen, the WebView shall emit the
+        event webkitfullscreenchange, but wk2gtk does not emit it. This is
+        because the WebView manages directly the exit of the full screen.
+
+        With this patch the WebView calls requestExitFullScreen to the full
+        screen manager, instead of managing directly the exit of the full
+        screen, and the event webkitfullscreenchange will be dispatched
+        correctly.
+
+        Reviewed by Martin Robinson.
+
+        No tests are included because there is a bug in WKTR that prevents the
+        execution of a test for this patch. See
+        https://bugs.webkit.org/show_bug.cgi?id=127348
+
+        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
+        (webkitWebViewBaseKeyPressEvent): Call
+        webkitWebViewBaseRequestExitFullScreen.
+        (webkitWebViewBaseRequestExitFullScreen): Added.
+        * UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Ditto.
+
 2014-01-24  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp

@@ -617 +617 @@
         case GDK_KEY_f:
         case GDK_KEY_F:
-            webkitWebViewBaseExitFullScreen(webViewBase);
+            webkitWebViewBaseRequestExitFullScreen(webViewBase);
             return TRUE;
         default:
@@ -1063 +1063 @@
 }
 
+void webkitWebViewBaseRequestExitFullScreen(WebKitWebViewBase* webkitWebViewBase)
+{
+#if ENABLE(FULLSCREEN_API)
+    webkitWebViewBase->priv->pageProxy->fullScreenManager()->requestExitFullScreen();
+#endif
+}
+
 void webkitWebViewBaseInitializeFullScreenClient(WebKitWebViewBase* webkitWebViewBase, const WKFullScreenClientGtkBase* wkClient)
 {

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBasePrivate.h

@@ -46 +46 @@
 void webkitWebViewBaseEnterFullScreen(WebKitWebViewBase*);
 void webkitWebViewBaseExitFullScreen(WebKitWebViewBase*);
+void webkitWebViewBaseRequestExitFullScreen(WebKitWebViewBase*);
 void webkitWebViewBaseInitializeFullScreenClient(WebKitWebViewBase*, const WKFullScreenClientGtkBase*);
 void webkitWebViewBaseSetInspectorViewSize(WebKitWebViewBase*, unsigned size);