Changeset 163177 in webkit

Timestamp:

Jan 31, 2014 10:49:13 AM (10 years ago)

Author:

Simon Fraser

Message:

Don't do logging from Range::collectSelectionRects() on iOS
​https://bugs.webkit.org/show_bug.cgi?id=127999

Reviewed by Enrica Casucci.

Remove some logging code that printed Range stuff in debug builds.

• dom/Range.cpp:

(WebCore::Range::collectSelectionRects):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Range.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-01-31  Simon Fraser  <simon.fraser@apple.com>
+
+        Don't do logging from Range::collectSelectionRects() on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=127999
+
+        Reviewed by Enrica Casucci.
+
+        Remove some logging code that printed Range stuff in debug builds.
+
+        * dom/Range.cpp:
+        (WebCore::Range::collectSelectionRects):
+
 2014-01-30  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/dom/Range.cpp

@@ -1698 +1698 @@
     return minEnd - maxStart >= sufficientOverlap * std::min(lengthA, lengthB);
 }
-
-#ifndef NDEBUG
-static void printRects(Vector<SelectionRect>& rects)
-{
-    size_t numberOfRects = rects.size();
-    for (size_t i = 0; i < numberOfRects; ++i) {
-        fprintf(stderr, "%zu\t[%d, %d] - [%d, %d]\t%c %s\tis first: %s\tis last:%s\tcontains start: %s\tcontains end: %s\tline: %d\truby: %s\tcolumn: %d\n",
-            i,
-            rects[i].rect().x(), rects[i].rect().y(), rects[i].rect().width(), rects[i].rect().height(),
-            rects[i].isHorizontal() ? 'H' : 'V',
-            rects[i].direction() == LTR ? "LTR" : "RTL",
-            rects[i].isFirstOnLine() ? "yes" : "no",
-            rects[i].isLastOnLine() ? "yes" : "no",
-            rects[i].containsStart() ? "yes" : "no",
-            rects[i].containsEnd() ? "yes" : "no",
-            rects[i].lineNumber(),
-            rects[i].isRubyText() ? "yes": "no",
-            rects[i].columnNumber());
-    }
-    fprintf(stderr, "--------------------------------------\n");
-}
-#endif
 
 static inline void adjustLineHeightOfSelectionRects(Vector<SelectionRect>& rects, size_t numberOfRects, int lineNumber, int lineTop, int lineHeight)
@@ -1791 +1769 @@
         }
     }
-
-#ifndef NDEBUG
-    printRects(rects);
-#endif
 
     // The range could span over nodes with different writing modes.