Changeset 163216 in webkit

Timestamp:

Jan 31, 2014, 3:57:29 PM (11 years ago)

Author:

Simon Fraser

Message:

Even when in fixed layout mode, some platforms need to do layout after a viewport change
​https://bugs.webkit.org/show_bug.cgi?id=128003

Reviewed by Andreas Kling.

Re-land 163182 with a less aggresive check in visibleContentsResized() for
needing to layout.

iOS uses fixed layout mode in both WK1 and WK2, but lays out fixed position
elements relative to a variable viewport. This code assumed that fixed layout
implies a fixed viewport.

Fix by testing for useCustomFixedPositionLayoutRect() in the fixed layout case.

Also removed RenderView::hasCustomFixedPosition() which is no longer used.

• page/FrameView.cpp:

(WebCore::FrameView::shouldLayoutAfterViewportChange):
(WebCore::FrameView::visibleContentsResized):

• page/FrameView.h:
• rendering/RenderView.cpp:
• rendering/RenderView.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/FrameView.cpp (modified) (2 diffs)
• page/FrameView.h (modified) (2 diffs)
• rendering/RenderView.cpp (modified) (1 diff)
• rendering/RenderView.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-01-31  Simon Fraser  <simon.fraser@apple.com>
+
+        Even when in fixed layout mode, some platforms need to do layout after a viewport change
+        https://bugs.webkit.org/show_bug.cgi?id=128003
+
+        Reviewed by Andreas Kling.
+        
+        Re-land 163182 with a less aggresive check in visibleContentsResized() for
+        needing to layout.
+
+        iOS uses fixed layout mode in both WK1 and WK2, but lays out fixed position
+        elements relative to a variable viewport. This code assumed that fixed layout
+        implies a fixed viewport.
+        
+        Fix by testing for useCustomFixedPositionLayoutRect() in the fixed layout case.
+        
+        Also removed RenderView::hasCustomFixedPosition() which is no longer used.
+        
+        * page/FrameView.cpp:
+        (WebCore::FrameView::shouldLayoutAfterViewportChange):
+        (WebCore::FrameView::visibleContentsResized):
+        * page/FrameView.h:
+        * rendering/RenderView.cpp:
+        * rendering/RenderView.h:
+
 2014-01-31  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Source/WebCore/page/FrameView.cpp

@@ -2140 +2140 @@
 }
 
+bool FrameView::shouldLayoutAfterContentsResized() const
+{
+    return !useFixedLayout() || useCustomFixedPositionLayoutRect();
+}
+
 void FrameView::visibleContentsResized()
 {
@@ -2161 +2166 @@
 #endif
 
-    if (!useFixedLayout() && needsLayout())
+    if (shouldLayoutAfterContentsResized() && needsLayout())
         layout();
 

trunk/Source/WebCore/page/FrameView.h

@@ -130 +130 @@
     void setCustomFixedPositionLayoutRect(const IntRect&);
     bool updateFixedPositionLayoutRect();
+#else
+    bool useCustomFixedPositionLayoutRect() const { return false; }
 #endif
 
@@ -487 +489 @@
     void updateCanBlitOnScrollRecursively();
     bool contentsInCompositedLayer() const;
+    bool shouldLayoutAfterContentsResized() const;
 
     bool shouldUpdateCompositingLayersAfterScrolling() const;

trunk/Source/WebCore/rendering/RenderView.cpp

@@ -1199 +1199 @@
 }
 
-#if PLATFORM(IOS)
-static bool isFixedPositionInViewport(const RenderObject& renderer, const RenderObject* container)
-{
-    return (renderer.style().position() == FixedPosition) && renderer.container() == container;
-}
-
-bool RenderView::hasCustomFixedPosition(const RenderObject& renderer, ContainingBlockCheck checkContainer) const
-{
-    if (!frameView().useCustomFixedPositionLayoutRect())
-        return false;
-
-    if (checkContainer == CheckContainingBlock)
-        return isFixedPositionInViewport(renderer, this);
-
-    return renderer.style().position() == FixedPosition;
-}
-#endif
-
 void RenderView::pushLayoutStateForCurrentFlowThread(const RenderObject& object)
 {

trunk/Source/WebCore/rendering/RenderView.h

@@ -192 +192 @@
     virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) override;
 
-#if PLATFORM(IOS)
-    enum ContainingBlockCheck { CheckContainingBlock, DontCheckContainingBlock };
-    bool hasCustomFixedPosition(const RenderObject&, ContainingBlockCheck = CheckContainingBlock) const;
-#endif
-
     IntervalArena* intervalArena();