Changeset 163957 in webkit

Timestamp:

Feb 12, 2014 5:31:22 AM (10 years ago)

Author:

stavila@adobe.com

Message:

[CSS Regions] Remove unused method in RenderFlowThread
​https://bugs.webkit.org/show_bug.cgi?id=128373

Reviewed by Mihnea Ovidenie.

After the landing of ​https://bugs.webkit.org/show_bug.cgi?id=118665, the
RenderFlowThread::computeRegionClippingRect method is obsolete.

No new tests needed, this patch only removes an unused method.

• rendering/RenderFlowThread.cpp:
• rendering/RenderFlowThread.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderFlowThread.cpp (modified) (1 diff)
• rendering/RenderFlowThread.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-02-12  Radu Stavila  <stavila@adobe.com>
+
+        [CSS Regions] Remove unused method in RenderFlowThread
+        https://bugs.webkit.org/show_bug.cgi?id=128373
+
+        Reviewed by Mihnea Ovidenie.
+
+        After the landing of https://bugs.webkit.org/show_bug.cgi?id=118665, the 
+        RenderFlowThread::computeRegionClippingRect method is obsolete.
+
+        No new tests needed, this patch only removes an unused method.
+
+        * rendering/RenderFlowThread.cpp:
+        * rendering/RenderFlowThread.h:
+
 2014-02-12  Mihai Tica  <mitica@adobe.com>
 

trunk/Source/WebCore/rendering/RenderFlowThread.cpp

@@ -389 +389 @@
             return;
     }
-}
-
-LayoutRect RenderFlowThread::computeRegionClippingRect(const LayoutPoint& offset, const LayoutRect& flowThreadPortionRect, const LayoutRect& flowThreadPortionOverflowRect) const
-{
-    LayoutRect regionClippingRect(offset + (flowThreadPortionOverflowRect.location() - flowThreadPortionRect.location()), flowThreadPortionOverflowRect.size());
-    if (style().isFlippedBlocksWritingMode())
-        regionClippingRect.move(flowThreadPortionRect.size() - flowThreadPortionOverflowRect.size());
-    return regionClippingRect;
 }
 

trunk/Source/WebCore/rendering/RenderFlowThread.h

@@ -232 +232 @@
     bool shouldRepaint(const LayoutRect&) const;
 
-    LayoutRect computeRegionClippingRect(const LayoutPoint&, const LayoutRect&, const LayoutRect&) const;
-
     bool updateAllLayerToRegionMappings();