Changeset 164015 in webkit

Timestamp:

Feb 12, 2014, 10:04:36 PM (12 years ago)

Author:

Antti Koivisto

Message:

Return immediately from DestroyPlugin IPC call
​https://bugs.webkit.org/show_bug.cgi?id=128712

Reviewed by Anders Carlsson.

In some cases we spend a lot of time waiting for synchronous IPC for plugin termination to complete. Reduce
the delay by returning from IPC immediately when the plugin process receives it. Just using asynchrounous
IPC might introduce undesirable arbitrary delay between the IPC call returning and the destruction actually
starting.

• PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::destroyPlugin):

• PluginProcess/WebProcessConnection.h:
• PluginProcess/WebProcessConnection.messages.in:

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• PluginProcess/WebProcessConnection.cpp (modified) (1 diff)
• PluginProcess/WebProcessConnection.h (modified) (1 diff)
• PluginProcess/WebProcessConnection.messages.in (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-02-12  Antti Koivisto  <antti@apple.com>
+
+        Return immediately from DestroyPlugin IPC call
+        https://bugs.webkit.org/show_bug.cgi?id=128712
+
+        Reviewed by Anders Carlsson.
+        
+        In some cases we spend a lot of time waiting for synchronous IPC for plugin termination to complete. Reduce
+        the delay by returning from IPC immediately when the plugin process receives it. Just using asynchrounous
+        IPC might introduce undesirable arbitrary delay between the IPC call returning and the destruction actually
+        starting.
+
+        * PluginProcess/WebProcessConnection.cpp:
+        (WebKit::WebProcessConnection::destroyPlugin):
+        * PluginProcess/WebProcessConnection.h:
+        * PluginProcess/WebProcessConnection.messages.in:
+
 2014-02-12  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebKit2/PluginProcess/WebProcessConnection.cpp

@@ -179 +179 @@
 }
 
-void WebProcessConnection::destroyPlugin(uint64_t pluginInstanceID, bool asynchronousCreationIncomplete)
-{
+void WebProcessConnection::destroyPlugin(uint64_t pluginInstanceID, bool asynchronousCreationIncomplete, PassRefPtr<Messages::WebProcessConnection::DestroyPlugin::DelayedReply> reply)
+{
+    // We return immediately from this synchronous IPC. We want to make sure the plugin destruction is just about to start so audio playback
+    // will finish soon after returning. However we don't want to wait for destruction to complete fully as that may take a while.
+    reply->send();
+
     // Ensure we don't clamp any timers during destruction
     ActivityAssertion activityAssertion(PluginProcess::shared().connectionActivity());

trunk/Source/WebKit2/PluginProcess/WebProcessConnection.h

@@ -73 +73 @@
     void createPlugin(const PluginCreationParameters&, PassRefPtr<Messages::WebProcessConnection::CreatePlugin::DelayedReply>);
     void createPluginAsynchronously(const PluginCreationParameters&);
-    void destroyPlugin(uint64_t pluginInstanceID, bool asynchronousCreationIncomplete);
+    void destroyPlugin(uint64_t pluginInstanceID, bool asynchronousCreationIncomplete, PassRefPtr<Messages::WebProcessConnection::DestroyPlugin::DelayedReply>);
     
     void createPluginInternal(const PluginCreationParameters&, bool& result, bool& wantsWheelEvents, uint32_t& remoteLayerClientID);

trunk/Source/WebKit2/PluginProcess/WebProcessConnection.messages.in

@@ -31 +31 @@
 
     # Destroys the plug-in instance with the given instance ID.
-    DestroyPlugin(uint64_t pluginInstanceID, bool asynchronousCreationIncomplete) -> ()
+    DestroyPlugin(uint64_t pluginInstanceID, bool asynchronousCreationIncomplete) -> () Delayed
 }