Changeset 164232 in webkit

Timestamp:

Feb 17, 2014 11:13:08 AM (10 years ago)

Author:

Simon Fraser

Message:

Graphics buffer issue with clip-path and fixed positioned element
​https://bugs.webkit.org/show_bug.cgi?id=126262

Source/WebCore:

Reviewed by Tim Horton.

If an element has a clip-path, backgroundIsKnownToBeOpaqueInRect() needs
to return false so that we don't try to make opaque compositing layers.

Test: compositing/contents-opaque/opaque-with-clip-path.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect):

LayoutTests:

Reviewed by Tim Horton.

• compositing/contents-opaque/opaque-with-clip-path-expected.html: Added.
• compositing/contents-opaque/opaque-with-clip-path.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/compositing/contents-opaque/opaque-with-clip-path-expected.html (added)
• LayoutTests/compositing/contents-opaque/opaque-with-clip-path.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderBox.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-02-17  Simon Fraser  <simon.fraser@apple.com>
+
+        Graphics buffer issue with clip-path and fixed positioned element
+        https://bugs.webkit.org/show_bug.cgi?id=126262
+
+        Reviewed by Tim Horton.
+
+        * compositing/contents-opaque/opaque-with-clip-path-expected.html: Added.
+        * compositing/contents-opaque/opaque-with-clip-path.html: Added.
+
 2014-02-17  Radu Stavila  <stavila@adobe.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-02-17  Simon Fraser  <simon.fraser@apple.com>
+
+        Graphics buffer issue with clip-path and fixed positioned element
+        https://bugs.webkit.org/show_bug.cgi?id=126262
+
+        Reviewed by Tim Horton.
+        
+        If an element has a clip-path, backgroundIsKnownToBeOpaqueInRect() needs
+        to return false so that we don't try to make opaque compositing layers.
+
+        Test: compositing/contents-opaque/opaque-with-clip-path.html
+
+        * rendering/RenderBox.cpp:
+        (WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect):
+
 2014-02-17  Radu Stavila  <stavila@adobe.com>
 

trunk/Source/WebCore/rendering/RenderBox.cpp

@@ -1290 +1290 @@
     // FIXME: Check the opaqueness of background images.
 
+    if (hasClipPath())
+        return false;
+
     // FIXME: Use rounded rect if border radius is present.
     if (style().hasBorderRadius())
         return false;
+    
     // FIXME: The background color clip is defined by the last layer.
     if (style().backgroundLayers()->next())