Changeset 164235 in webkit

Timestamp:

Feb 17, 2014 11:26:55 AM (10 years ago)

Author:

andersca@apple.com

Message:

WebKitGTK+ should stop calling functions to set the view source mode
​https://bugs.webkit.org/show_bug.cgi?id=128919

Reviewed by Carlos Garcia Campos.

This is a first step towards getting rid of the view source mode from WebCore.
View source shouldn't be a mode on the web page and can be implemented in other ways by
embedding apps. Furthermore, the inspector has an excellent view source mode.

Source/WebKit/gtk:

• webkit/webkitwebview.cpp:

(webkit_web_view_set_view_source_mode):
(webkit_web_view_get_view_source_mode):
Turn these into no-ops.

Source/WebKit2:

• UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_set_view_mode):
(webkit_web_view_get_view_mode):
Turn these into no-ops.

Location:

trunk/Source

Files:

• WebKit/gtk/ChangeLog (modified) (1 diff)
• WebKit/gtk/webkit/webkitwebview.cpp (modified) (2 diffs)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (modified) (3 diffs)

trunk/Source/WebKit/gtk/ChangeLog

@@ +1 @@
+2014-02-17  Anders Carlsson  <andersca@apple.com>
+
+        WebKitGTK+ should stop calling functions to set the view source mode
+        https://bugs.webkit.org/show_bug.cgi?id=128919
+
+        Reviewed by Carlos Garcia Campos.
+
+        This is a first step towards getting rid of the view source mode from WebCore. 
+        View source shouldn't be a mode on the web page and can be implemented in other ways by
+        embedding apps. Furthermore, the inspector has an excellent view source mode.
+
+        * webkit/webkitwebview.cpp:
+        (webkit_web_view_set_view_source_mode):
+        (webkit_web_view_get_view_source_mode):
+        Turn these into no-ops.
+
 2014-02-11  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp

@@ -5192 +5192 @@
     g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView));
 
-    core(webView)->mainFrame().setInViewSourceMode(mode);
+    g_warning("webkit_web_view_set_view_source_mode has been deprecated and is a no-op.");
 }
 
@@ -5207 +5207 @@
     g_return_val_if_fail(WEBKIT_IS_WEB_VIEW(webView), FALSE);
 
-    return core(webView)->mainFrame().inViewSourceMode();
+    g_warning("webkit_web_view_get_view_source_mode has been deprecated and always returns FALSE.");
+    return FALSE;
 }
 

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-02-17  Anders Carlsson  <andersca@apple.com>
+
+        WebKitGTK+ should stop calling functions to set the view source mode
+        https://bugs.webkit.org/show_bug.cgi?id=128919
+
+        Reviewed by Carlos Garcia Campos.
+
+        This is a first step towards getting rid of the view source mode from WebCore. 
+        View source shouldn't be a mode on the web page and can be implemented in other ways by
+        embedding apps. Furthermore, the inspector has an excellent view source mode.
+
+        * UIProcess/API/gtk/WebKitWebView.cpp:
+        (webkit_web_view_set_view_mode):
+        (webkit_web_view_get_view_mode):
+        Turn these into no-ops.
+
 2014-02-17  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp

@@ -164 +164 @@
     CString activeURI;
     bool isLoading;
-    WebKitViewMode viewMode;
 
     bool waitingForMainResource;
@@ -3034 +3033 @@
     g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView));
 
-    if (webView->priv->viewMode == viewMode)
-        return;
-
-    getPage(webView)->setMainFrameInViewSourceMode(viewMode == WEBKIT_VIEW_MODE_SOURCE);
-
-    webView->priv->viewMode = viewMode;
-    g_object_notify(G_OBJECT(webView), "view-mode");
+    g_warning("webkit_web_view_set_view_mode has been deprecated and is a no-op.");
 }
 
@@ -3055 +3048 @@
     g_return_val_if_fail(WEBKIT_IS_WEB_VIEW(webView), WEBKIT_VIEW_MODE_WEB);
 
-    return webView->priv->viewMode;
+    g_warning("webkit_web_view_get_view_mode has been deprecated and always returns WEBKIT_VIEW_MODE_WEB.");
+    return WEBKIT_VIEW_MODE_WEB;
 }