Changeset 164320 in webkit

Timestamp:

Feb 18, 2014 2:37:58 PM (10 years ago)

Author:

rniwa@webkit.org

Message:

Merge notifyComponentsOnChangedSelection into respondToSelectionChange
​https://bugs.webkit.org/show_bug.cgi?id=128993

Reviewed by Andreas Kling.

Merged notifyComponentsOnChangedSelection into respondToSelectionChange since notifyComponentsOnChangedSelection
was only added in iOS codebase in response to the code added for continuous spellchecking and alternative text controller
in respondToChangedSelection but they should have been called inside setIgnoreCompositionSelectionChange.

So merge these two functions and make respondToChangedSelection behave like setIgnoreCompositionSelectionChange.

• editing/Editor.cpp:

(WebCore::Editor::setIgnoreCompositionSelectionChange):
(WebCore::Editor::respondToChangedSelection):

• editing/Editor.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/Editor.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-02-18 Ryosuke Niwa <rniwa@webkit.org>
+
+        Merge notifyComponentsOnChangedSelection into respondToSelectionChange
+        https://bugs.webkit.org/show_bug.cgi?id=128993
+
+        Reviewed by Andreas Kling.
+
+        Merged notifyComponentsOnChangedSelection into respondToSelectionChange since notifyComponentsOnChangedSelection
+        was only added in iOS codebase in response to the code added for continuous spellchecking and alternative text controller
+        in respondToChangedSelection but they should have been called inside setIgnoreCompositionSelectionChange.
+
+        So merge these two functions and make respondToChangedSelection behave like setIgnoreCompositionSelectionChange.
+
+        * editing/Editor.cpp:
+        (WebCore::Editor::setIgnoreCompositionSelectionChange):
+        (WebCore::Editor::respondToChangedSelection):
+        * editing/Editor.h:
+
 2014-02-18  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/editing/Editor.cpp

@@ -757 +757 @@
 {
 #if PLATFORM(IOS)
-    // FIXME: Merge this to open source https://bugs.webkit.org/show_bug.cgi?id=38830
+    // FIXME: Should suppress selection change notifications during a composition change <https://webkit.org/b/38830>
     if (m_ignoreCompositionSelectionChange)
         return;
@@ -2950 +2950 @@
     // starts a new kill ring sequence, but we want to do these things (matches AppKit).
 #if PLATFORM(IOS)
-    // FIXME: Merge this to open source https://bugs.webkit.org/show_bug.cgi?id=38830
+    // FIXME: Should suppress selection change notifications during a composition change <https://webkit.org/b/38830>
     if (m_ignoreCompositionSelectionChange)
         return;