Changeset 164369 in webkit

Timestamp:

Feb 19, 2014, 10:04:39 AM (11 years ago)

Author:

Antti Koivisto

Message:

Don't call to willBeDeletedFrom(Document&) when destructing document
​https://bugs.webkit.org/show_bug.cgi?id=129013

Reviewed by Andreas Kling.

The document is half dead at this point.

• dom/ContainerNode.cpp:

(WebCore::ContainerNode::~ContainerNode):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/ContainerNode.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-02-19  Antti Koivisto  <antti@apple.com>
+
+        Don't call to willBeDeletedFrom(Document&) when destructing document
+        https://bugs.webkit.org/show_bug.cgi?id=129013
+
+        Reviewed by Andreas Kling.
+        
+        The document is half dead at this point.
+
+        * dom/ContainerNode.cpp:
+        (WebCore::ContainerNode::~ContainerNode):
+
 2014-02-19  Daniel Bates  <dabates@apple.com>
 

trunk/Source/WebCore/dom/ContainerNode.cpp

@@ -151 +151 @@
 ContainerNode::~ContainerNode()
 {
-    willBeDeletedFrom(document());
+    if (!isDocumentNode())
+        willBeDeletedFrom(document());
     removeDetachedChildren();
 }