Changeset 164406 in webkit

Timestamp:

Feb 19, 2014 6:03:40 PM (10 years ago)

Author:

Simon Fraser

Message:

Avoid sending redundant layer properties to the UI process, and avoid allocation of RemoteLayerBackingStore unless we need it
​https://bugs.webkit.org/show_bug.cgi?id=129076

Reviewed by Tim Horton.

Normally we rely on GraphicsLayerCA to avoid redundant property
setting on PlatformCALayers, but for contents layers GraphicsLayerCA
sets properties on every update.

Make PlatformCALayerRemote more efficient in this case by not
setting dirty flags for unchanged property sets.

Also avoid creation of RemoteLayerBackingStore unless we
actually need one.

• WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::ensureBackingStore):
(PlatformCALayerRemote::updateBackingStore):
(PlatformCALayerRemote::setBounds):
(PlatformCALayerRemote::setPosition):
(PlatformCALayerRemote::setAnchorPoint):
(PlatformCALayerRemote::setMasksToBounds):
(PlatformCALayerRemote::setAcceleratesDrawing):
(PlatformCALayerRemote::setBorderWidth):
(PlatformCALayerRemote::setBorderColor):
(PlatformCALayerRemote::setContentsScale):

• WebProcess/WebPage/mac/PlatformCALayerRemote.h:

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/mac/PlatformCALayerRemote.cpp (modified) (10 diffs)
• WebProcess/WebPage/mac/PlatformCALayerRemote.h (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-02-19  Simon Fraser  <simon.fraser@apple.com>
+
+        Avoid sending redundant layer properties to the UI process, and avoid allocation of RemoteLayerBackingStore unless we need it
+        https://bugs.webkit.org/show_bug.cgi?id=129076
+
+        Reviewed by Tim Horton.
+        
+        Normally we rely on GraphicsLayerCA to avoid redundant property
+        setting on PlatformCALayers, but for contents layers GraphicsLayerCA
+        sets properties on every update.
+        
+        Make PlatformCALayerRemote more efficient in this case by not
+        setting dirty flags for unchanged property sets.
+        
+        Also avoid creation of RemoteLayerBackingStore unless we
+        actually need one.
+
+        * WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
+        (PlatformCALayerRemote::ensureBackingStore):
+        (PlatformCALayerRemote::updateBackingStore):
+        (PlatformCALayerRemote::setBounds):
+        (PlatformCALayerRemote::setPosition):
+        (PlatformCALayerRemote::setAnchorPoint):
+        (PlatformCALayerRemote::setMasksToBounds):
+        (PlatformCALayerRemote::setAcceleratesDrawing):
+        (PlatformCALayerRemote::setBorderWidth):
+        (PlatformCALayerRemote::setBorderColor):
+        (PlatformCALayerRemote::setContentsScale):
+        * WebProcess/WebPage/mac/PlatformCALayerRemote.h:
+
 2014-02-19  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp

@@ -152 +152 @@
     if (!m_properties.backingStore)
         m_properties.backingStore = std::make_unique<RemoteLayerBackingStore>();
+
+    updateBackingStore();
+}
+
+void PlatformCALayerRemote::updateBackingStore()
+{
+    if (!m_properties.backingStore)
+        return;
+
     m_properties.backingStore->ensureBackingStore(this, expandedIntSize(m_properties.size), m_properties.contentsScale, m_acceleratesDrawing);
 }
@@ -305 +314 @@
 void PlatformCALayerRemote::setBounds(const FloatRect& value)
 {
+    if (value.size() == m_properties.size)
+        return;
+
     m_properties.size = value.size();
     m_properties.notePropertiesChanged(RemoteLayerTreeTransaction::SizeChanged);
@@ -311 +323 @@
         m_properties.notePropertiesChanged(RemoteLayerTreeTransaction::CustomAppearanceChanged);
 
-    ensureBackingStore();
+    updateBackingStore();
 }
 
@@ -321 +333 @@
 void PlatformCALayerRemote::setPosition(const FloatPoint3D& value)
 {
+    if (value == m_properties.position)
+        return;
+
     m_properties.position = value;
     m_properties.notePropertiesChanged(RemoteLayerTreeTransaction::PositionChanged);
@@ -332 +347 @@
 void PlatformCALayerRemote::setAnchorPoint(const FloatPoint3D& value)
 {
+    if (value == m_properties.anchorPoint)
+        return;
+
     m_properties.anchorPoint = value;
     m_properties.notePropertiesChanged(RemoteLayerTreeTransaction::AnchorPointChanged);
@@ -388 +406 @@
 void PlatformCALayerRemote::setMasksToBounds(bool value)
 {
+    if (value == m_properties.masksToBounds)
+        return;
+
     m_properties.masksToBounds = value;
     m_properties.notePropertiesChanged(RemoteLayerTreeTransaction::MasksToBoundsChanged);
@@ -400 +421 @@
 {
     m_acceleratesDrawing = acceleratesDrawing;
-    ensureBackingStore();
+    updateBackingStore();
 }
 
@@ -443 +464 @@
 void PlatformCALayerRemote::setBorderWidth(float value)
 {
+    if (value == m_properties.borderWidth)
+        return;
+
     m_properties.borderWidth = value;
     m_properties.notePropertiesChanged(RemoteLayerTreeTransaction::BorderWidthChanged);
@@ -449 +473 @@
 void PlatformCALayerRemote::setBorderColor(const Color& value)
 {
+    if (value == m_properties.borderColor)
+        return;
+
     m_properties.borderColor = value;
     m_properties.notePropertiesChanged(RemoteLayerTreeTransaction::BorderColorChanged);
@@ -510 +537 @@
     m_properties.notePropertiesChanged(RemoteLayerTreeTransaction::ContentsScaleChanged);
 
-    ensureBackingStore();
+    updateBackingStore();
 }
 

trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.h

@@ -156 +156 @@
     virtual bool isPlatformCALayerRemote() const override { return true; }
     void ensureBackingStore();
+    void updateBackingStore();
     void removeSublayer(PlatformCALayerRemote*);