Changeset 164640 in webkit

Timestamp:

Feb 25, 2014 2:16:04 AM (10 years ago)

Author:

commit-queue@webkit.org

Message:

[CSS Blending] -webkit-mix-blend-mode should force transform-style: flat.
​https://bugs.webkit.org/show_bug.cgi?id=126158

Patch by Mihai Tica <​mitica@adobe.com> on 2014-02-25
Reviewed by Mihnea Ovidenie.

Source/WebCore:

As stated in the ​http://www.w3.org/TR/css3-transforms/#propdef-transform-style, an element with blending
should force transform-style: flat.

Test: css3/compositing/blend-mode-transform-style.html

• css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle): If blending is detected, set transform-style to flat.

LayoutTests:

For an element with -webkit-mix-blend-mode, test that the value of -webkit-transform-style computes to flat.

• css3/compositing/blend-mode-transform-style-expected.txt: Added.
• css3/compositing/blend-mode-transform-style.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/css3/compositing/blend-mode-transform-style-expected.txt (added)
• LayoutTests/css3/compositing/blend-mode-transform-style.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/StyleResolver.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-02-25  Mihai Tica  <mitica@adobe.com>
+
+        [CSS Blending] -webkit-mix-blend-mode should force transform-style: flat.
+        https://bugs.webkit.org/show_bug.cgi?id=126158
+
+        Reviewed by Mihnea Ovidenie.
+
+        For an element with -webkit-mix-blend-mode, test that the value of -webkit-transform-style computes to flat.
+
+        * css3/compositing/blend-mode-transform-style-expected.txt: Added.
+        * css3/compositing/blend-mode-transform-style.html: Added.
+
 2014-02-24  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-02-25  Mihai Tica  <mitica@adobe.com>
+
+        [CSS Blending] -webkit-mix-blend-mode should force transform-style: flat.
+        https://bugs.webkit.org/show_bug.cgi?id=126158
+
+        Reviewed by Mihnea Ovidenie.
+
+        As stated in the http://www.w3.org/TR/css3-transforms/#propdef-transform-style, an element with blending
+        should force transform-style: flat.
+
+        Test: css3/compositing/blend-mode-transform-style.html
+
+        * css/StyleResolver.cpp:
+        (WebCore::StyleResolver::adjustRenderStyle): If blending is detected, set transform-style to flat.
+
 2014-02-25  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/css/StyleResolver.cpp

@@ -1329 +1329 @@
     if (style.preserves3D() && (style.overflowX() != OVISIBLE
         || style.overflowY() != OVISIBLE
-        || style.hasFilter()))
+        || style.hasFilter()
+        || style.hasBlendMode()))
         style.setTransformStyle3D(TransformStyle3DFlat);