Changeset 164787 in webkit

Timestamp:

Feb 27, 2014 3:30:23 AM (10 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] Web Inspector doesn't work with network process enabled
​https://bugs.webkit.org/show_bug.cgi?id=127651

Reviewed by Sergio Villar Senin.

The problem is that the web inspector loads so many resources,
that when using the network process, a lot of IPC traffic is
generated causing the send buffer of the socket to be full. When
that happens sendmsg() fails with EAGAIN, because we are using non
blocking sockets, and we are not handling neither EAGAIN nor
EWOULDBLOCK errors (we do when reading from the socket, though).

• Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::Connection::readyReadHandler): Add a log message to know
when reading from the socket fails for any unhandled error.
(IPC::Connection::sendOutgoingMessage): Handle EAGAIN and
EWOULDBLOCK errors to try again in those cases. Also add a log
message for unhandled errors.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Platform/IPC/unix/ConnectionUnix.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-02-27  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Web Inspector doesn't work with network process enabled
+        https://bugs.webkit.org/show_bug.cgi?id=127651
+
+        Reviewed by Sergio Villar Senin.
+
+        The problem is that the web inspector loads so many resources,
+        that when using the network process, a lot of IPC traffic is
+        generated causing the send buffer of the socket to be full. When
+        that happens sendmsg() fails with EAGAIN, because we are using non
+        blocking sockets, and we are not handling neither EAGAIN nor
+        EWOULDBLOCK errors (we do when reading from the socket, though).
+
+        * Platform/IPC/unix/ConnectionUnix.cpp:
+        (IPC::Connection::readyReadHandler): Add a log message to know
+        when reading from the socket fails for any unhandled error.
+        (IPC::Connection::sendOutgoingMessage): Handle EAGAIN and
+        EWOULDBLOCK errors to try again in those cases. Also add a log
+        message for unhandled errors.
+
 2014-02-26  Philippe Normand  <pnormand@igalia.com>
 

trunk/Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp

@@ -358 +358 @@
 
             // FIXME: Handle other errors here?
+            WTFLogAlways("Error receiving IPC message: %s", strerror(errno));
             return;
         }
@@ -522 +523 @@
     int bytesSent = 0;
     while ((bytesSent = sendmsg(m_socketDescriptor, &message, 0)) == -1) {
-        if (errno != EINTR)
-            return false;
+        if (errno == EINTR || errno == EAGAIN || errno == EWOULDBLOCK)
+            continue;
+
+        WTFLogAlways("Error sending IPC message: %s", strerror(errno));
+        return false;
     }
     return true;