Changeset 164831 in webkit

Timestamp:

Feb 27, 2014 2:55:44 PM (10 years ago)

Author:

Simon Fraser

Message:

Crash tapping on play button on video on iOS
​https://bugs.webkit.org/show_bug.cgi?id=129452

Reviewed by Benjamin Poulain.

node->computedStyle() can return null. Just use
renderer->style() to get the tap highlight color.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::tapHighlightAtPosition):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/ios/WebPageIOS.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-02-27  Simon Fraser  <simon.fraser@apple.com>
+
+        Crash tapping on play button on video on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=129452
+
+        Reviewed by Benjamin Poulain.
+        
+        node->computedStyle() can return null. Just use
+        renderer->style() to get the tap highlight color.
+
+        * WebProcess/WebPage/ios/WebPageIOS.mm:
+        (WebKit::WebPage::tapHighlightAtPosition):
+
 2014-02-27  Brian Burg  <bburg@apple.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm

@@ -368 +368 @@
     if (renderer) {
         renderer->absoluteQuads(quads);
-        Color highlightColor = node->computedStyle()->tapHighlightColor();
+        Color highlightColor = renderer->style().tapHighlightColor();
         if (!node->document().frame()->isMainFrame()) {
             FrameView* view = node->document().frame()->view();