Changeset 164931 in webkit


Ignore:
Timestamp:
Mar 1, 2014 3:31:03 PM (10 years ago)
Author:
psolanki@apple.com
Message:

[iOS] selectionImageForcingBlackText should return autoreleased object
https://bugs.webkit.org/show_bug.cgi?id=129437
<rdar://problem/15810384>

Reviewed by Darin Adler.

Source/WebCore:

  • bindings/objc/DOM.mm:

(-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]):

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):

Location:
trunk/Source
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r164929 r164931  
     12014-03-01  Pratik Solanki  <psolanki@apple.com>
     2
     3        [iOS] selectionImageForcingBlackText should return autoreleased object
     4        https://bugs.webkit.org/show_bug.cgi?id=129437
     5        <rdar://problem/15810384>
     6
     7        Reviewed by Darin Adler.
     8
     9        * bindings/objc/DOM.mm:
     10        (-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]):
     11
    1122014-03-01  Yoav Weiss  <yoav@yoav.ws>
    213
  • trunk/Source/WebCore/bindings/objc/DOM.mm

    r162820 r164931  
    612612
    613613#if PLATFORM(IOS)
    614     return createDragImageForRange(*frame, *range, forceBlackText).leakRef();
     614    CGImageRef dragImage = createDragImageForRange(*frame, *range, forceBlackText).leakRef();
     615    return dragImage ? (CGImageRef)CFAutorelease(dragImage) : nil;
    615616#else
    616617    return [createDragImageForRange(*frame, *range, forceBlackText).leakRef() autorelease];
  • trunk/Source/WebKit/mac/ChangeLog

    r164908 r164931  
     12014-03-01  Pratik Solanki  <psolanki@apple.com>
     2
     3        [iOS] selectionImageForcingBlackText should return autoreleased object
     4        https://bugs.webkit.org/show_bug.cgi?id=129437
     5        <rdar://problem/15810384>
     6
     7        Reviewed by Darin Adler.
     8
     9        * WebView/WebHTMLView.mm:
     10        (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
     11
    1122014-02-28  Dan Bernstein  <mitz@apple.com>
    213
  • trunk/Source/WebKit/mac/WebView/WebHTMLView.mm

    r163739 r164931  
    65706570
    65716571#if PLATFORM(IOS)
    6572     return createDragImageForSelection(*coreFrame, forceBlackText).leakRef();
     6572    CGImageRef dragImage = createDragImageForSelection(*coreFrame, forceBlackText).leakRef();
     6573    return dragImage ? (CGImageRef)CFAutorelease(dragImage) : nil;
    65736574#else
    65746575    return [createDragImageForSelection(*coreFrame, forceBlackText).leakRef() autorelease];
Note: See TracChangeset for help on using the changeset viewer.