Changeset 164967 in webkit

Timestamp:

Mar 2, 2014 8:49:38 PM (10 years ago)

Author:

timothy@apple.com

Message:

Remove ASSERT in ~IDBRequest since it is firing during legitimate uses in Web Inspector.

Adding the ASSERT back is tracked by ​https://webkit.org/b/129593.

​https://bugs.webkit.org/show_bug.cgi?id=129328

Reviewed by Sam Weinig.

Source/WebCore:

• Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::~IDBRequest):

LayoutTests:

• TestExpectations: Remove skipped tests.
• inspector-protocol/model/probe-manager-add-remove-actions-expected.txt: Rebaselined.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/TestExpectations (modified) (1 diff)
• LayoutTests/inspector-protocol/model/probe-manager-add-remove-actions-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/indexeddb/IDBRequest.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-03-02  Timothy Hatcher  <timothy@apple.com>
+
+        Remove ASSERT in ~IDBRequest since it is firing during legitimate uses in Web Inspector.
+
+        Adding the ASSERT back is tracked by https://webkit.org/b/129593.
+
+        https://bugs.webkit.org/show_bug.cgi?id=129328
+
+        Reviewed by Sam Weinig.
+
+        * TestExpectations: Remove skipped tests.
+        * inspector-protocol/model/probe-manager-add-remove-actions-expected.txt: Rebaselined.
+
 2014-03-02  Brian Burg  <bburg@apple.com>
 

trunk/LayoutTests/TestExpectations

@@ -96 +96 @@
 webkit.org/b/129327 inspector-protocol/indexeddb/basics.html [ Pass Failure ]
 
-# These assert in IndexedDB code very freqyently.
-webkit.org/b/129328 inspector-protocol/model [ Skip ]
-
 # Apparent fallout from http://trac.webkit.org/changeset/164830
 webkit.org/b/129462 [ Release ] inspector-protocol/dom/dom-search-crash.html [ Skip ]

trunk/LayoutTests/inspector-protocol/model/probe-manager-add-remove-actions-expected.txt

@@ -9 +9 @@
 Probe set's probe count: 2
 Breakpoint actions changed. New count: 2
+Breakpoint resolved state changed: true
+Breakpoint resolved state changed: true
+Breakpoint resolved state changed: false
 Breakpoint was added.
 PASS: Breakpoint should be resolved.

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-03-02  Timothy Hatcher  <timothy@apple.com>
+
+        Remove ASSERT in ~IDBRequest since it is firing during legitimate uses in Web Inspector.
+
+        Adding the ASSERT back is tracked by https://webkit.org/b/129593.
+
+        https://bugs.webkit.org/show_bug.cgi?id=129328
+
+        Reviewed by Sam Weinig.
+
+        * Modules/indexeddb/IDBRequest.cpp:
+        (WebCore::IDBRequest::~IDBRequest):
+
 2014-03-02  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp

@@ -91 +91 @@
 IDBRequest::~IDBRequest()
 {
-    ASSERT(m_readyState == DONE || m_readyState == EarlyDeath || !scriptExecutionContext());
 }