Changeset 165037 in webkit

Timestamp:

Mar 3, 2014 10:37:43 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

:active style is not cleared when its display property is set to none before mouse released.
​https://bugs.webkit.org/show_bug.cgi?id=129465

Patch by Sanghyup Lee <​sh53.lee@samsung.com> on 2014-03-03
Reviewed by Antonio Gomes.

Source/WebCore:

We currently clearing the :active style when element has a renderer.
This patch makes elements clear its active style regardless of renderer.

• dom/Document.cpp:

(WebCore::Document::updateHoverActiveState):

LayoutTests:

• fast/css/active-display-none-expected.txt: Added.
• fast/css/active-display-none.html: Added.

Location:

trunk

Files:

• LayoutTests/fast/css/active-display-none-expected.txt (added)
• LayoutTests/fast/css/active-display-none.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/Document.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-03-03  Sanghyup Lee  <sh53.lee@samsung.com>
+
+        :active style is not cleared when its display property is set to none before mouse released.
+        https://bugs.webkit.org/show_bug.cgi?id=129465
+
+        Reviewed by Antonio Gomes.
+
+        Source/WebCore:
+
+        We currently clearing the :active style when element has a renderer.
+        This patch makes elements clear its active style regardless of renderer. 
+
+        * dom/Document.cpp:
+        (WebCore::Document::updateHoverActiveState):
+
+        LayoutTests:
+
+        * fast/css/active-display-none-expected.txt: Added.
+        * fast/css/active-display-none.html: Added.
+
+
 2014-03-03  Andreas Kling  <akling@apple.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -5836 +5836 @@
     if (oldActiveElement && !request.active()) {
         // We are clearing the :active chain because the mouse has been released.
-        for (RenderElement* curr = oldActiveElement->renderer(); curr; curr = curr->parent()) {
-            Element* element = curr->element();
-            if (!element)
-                continue;
-            element->setActive(false);
-            m_userActionElements.setInActiveChain(element, false);
+        for (Element* curr = oldActiveElement; curr; curr = curr->parentElement()) {
+            curr->setActive(false);
+            m_userActionElements.setInActiveChain(curr, false);
         }
         m_activeElement.clear();