Changeset 165064 in webkit

Timestamp:

Mar 4, 2014 11:43:49 AM (10 years ago)

Author:

Simon Fraser

Message:

Crashes and assertions running iOS compositing tests
​https://bugs.webkit.org/show_bug.cgi?id=129688

Reviewed by Dean Jackson.

When a layer is no longer composited, we need to unregister it
from the scrolling coordinator, and remove it from m_scrollCoordinatedLayers.

Tested by compositing tests on iOS.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderLayerCompositor.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-03-04  Simon Fraser  <simon.fraser@apple.com>
+
+        Crashes and assertions running iOS compositing tests
+        https://bugs.webkit.org/show_bug.cgi?id=129688
+
+        Reviewed by Dean Jackson.
+        
+        When a layer is no longer composited, we need to unregister it
+        from the scrolling coordinator, and remove it from m_scrollCoordinatedLayers.
+
+        Tested by compositing tests on iOS.
+
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::RenderLayerCompositor::updateBacking):
+
 2014-03-04  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp

@@ -808 +808 @@
             }
 
-            detachScrollCoordinatedLayer(layer);
-            
+            removeFromScrollCoordinatedLayers(layer);
+
             layer.clearBacking();
             layerChanged = true;
@@ -3374 +3374 @@
     m_scrollCoordinatedLayers.remove(&layer);
     m_scrollCoordinatedLayersNeedingUpdate.remove(&layer);
+
+    detachScrollCoordinatedLayer(layer);
 }