Changeset 165575 in webkit

Timestamp:

Mar 13, 2014 4:48:52 PM (10 years ago)

Author:

akling@apple.com

Message:

Revert "Short-circuit JSGlobalObjectInspectorController when not inspecting."
<​https://webkit.org/b/129995>

This code path is not taken anymore on DYEB, and I can't explain why
it was showing up in my profiles. Backing it out per JoePeck's suggestion.

• inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::reportAPIException):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/JSGlobalObjectInspectorController.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2014-03-13  Andreas Kling  <akling@apple.com>
+
+        Revert "Short-circuit JSGlobalObjectInspectorController when not inspecting."
+        <https://webkit.org/b/129995>
+
+        This code path is not taken anymore on DYEB, and I can't explain why
+        it was showing up in my profiles. Backing it out per JoePeck's suggestion.
+
+        * inspector/JSGlobalObjectInspectorController.cpp:
+        (Inspector::JSGlobalObjectInspectorController::reportAPIException):
+
 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp

@@ -142 +142 @@
 void JSGlobalObjectInspectorController::reportAPIException(ExecState* exec, JSValue exception)
 {
-    if (!m_consoleAgent->enabled())
-        return;
-
     if (isTerminatedExecutionException(exception))
         return;