Changeset 166038 in webkit

Timestamp:

Mar 20, 2014 9:05:05 PM (10 years ago)

Author:

zoltan@webkit.org

Message:

Add option for hiding Confidence Interval Delta on the performance tests results page
​https://bugs.webkit.org/show_bug.cgi?id=130483

Reviewed by Ryosuke Niwa.

I've found it useful to hide the confidence interval delta from the results table
sometimes, for example on copying data, or for a clearer look. This patch introduces
a new button for it on the local results page.

• resources/results-template.html:

Location:

trunk/PerformanceTests

Files:

• ChangeLog (modified) (1 diff)
• resources/results-template.html (modified) (8 diffs)

trunk/PerformanceTests/ChangeLog

@@ +1 @@
+2014-03-20  Zoltan Horvath  <zoltan@webkit.org>
+
+        Add option for hiding Confidence Interval Delta on the performance tests results page
+        https://bugs.webkit.org/show_bug.cgi?id=130483
+
+        Reviewed by Ryosuke Niwa.
+
+        I've found it useful to hide the confidence interval delta from the results table
+        sometimes, for example on copying data, or for a clearer look. This patch introduces
+        a new button for it on the local results page.
+
+        * resources/results-template.html:
+
 2014-03-20  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
 

trunk/PerformanceTests/resources/results-template.html

@@ -133 +133 @@
 Result <span id="time-memory" class="checkbox"><span class="checked">Time</span><span>Memory</span></span>
 Reference <span id="reference" class="checkbox"></span>
+<span title="Confidence Interval Delta">CI&#916;</span> <span id="confidenceIntervalDelta" class="checkbox"><span class="checked">Show</span><span>Hide</span></span>
 </div>
 <table id="container"></table>
@@ -390 +391 @@
 }
 
-function createTable(tests, runs, shouldIgnoreMemory, referenceIndex) {
+function createTable(tests, runs, shouldIgnoreMemory, referenceIndex, hideConfidenceIntervalDelta) {
     $('#container').html('<thead><tr><th>Test</th><th>Unit</th>' + runs.map(function (run, index) {
-        return '<th colspan="' + (index == referenceIndex ? 2 : 3) + '" class="{sorter: \'comparison\'}">' + run.label() + '</th>';
+        var colspan = 2;
+        if (index != referenceIndex)
+            colspan = 3;
+        if (hideConfidenceIntervalDelta)
+            colspan--;
+        return '<th colspan="' + colspan + '" class="{sorter: \'comparison\'}">' + run.label() + '</th>';
     }).reduce(function (markup, cell) { return markup + cell; }, '') + '</tr></head><tbody></tbody>');
 
@@ -402 +408 @@
         var test = tests[testName];
         if (test.isMemoryTest() != shouldIgnoreMemory)
-            createTableRow(runs, test, referenceIndex);
+            createTableRow(runs, test, referenceIndex, hideConfidenceIntervalDelta);
     });
 
@@ -446 +452 @@
     + '</svg>';
 
-function createTableRow(runs, test, referenceIndex) {
+function createTableRow(runs, test, referenceIndex, hideConfidenceIntervalDelta) {
     var tableRow = $('<tr><td class="test">' + test.name() + '</td><td class="unit">' + test.unit() + '</td></tr>');
 
@@ -482 +488 @@
             + ', max=' + toFixedWidthPrecision(result.max()) + '\n' + regressionAnalysis;
 
+        var confidenceIntervalDeltaCell = '';
+        if (!hideConfidenceIntervalDelta) {
+            confidenceIntervalDeltaCell = '<td class="confidenceIntervalDelta" title="' + statistics + '">&plusmn; '
+                + formatPercentage(result.confidenceIntervalDeltaRatio()) + warning + '</td>';
+        }
+
         // Tablesorter doesn't know about the second cell so put the comparison in the invisible element.
         return '<td class="result" title="' + statistics + '">' + toFixedWidthPrecision(result.mean()) + hiddenValue
-            + '</td><td class="confidenceIntervalDelta" title="' + statistics + '">&plusmn; '
-            + formatPercentage(result.confidenceIntervalDeltaRatio()) + warning + '</td>' + comparisonCell;
+            + '</td>' + confidenceIntervalDeltaCell + comparisonCell;
     }
 
@@ -581 +592 @@
     var shouldIgnoreMemory= true;
     var referenceIndex = 0;
+    var hideConfidenceIntervalDelta = false;
 
     createTable(metrics, runs, shouldIgnoreMemory, referenceIndex);
@@ -586 +598 @@
     $('#time-memory').bind('change', function (event, checkedElement) {
         shouldIgnoreMemory = checkedElement.textContent == 'Time';
-        createTable(metrics, runs, shouldIgnoreMemory, referenceIndex);
+        createTable(metrics, runs, shouldIgnoreMemory, referenceIndex, hideConfidenceIntervalDelta);
     });
 
@@ -595 +607 @@
     $('#reference').bind('change', function (event, checkedElement) {
         referenceIndex = parseInt(checkedElement.getAttribute('value'));
-        createTable(metrics, runs, shouldIgnoreMemory, referenceIndex);
+        createTable(metrics, runs, shouldIgnoreMemory, referenceIndex, hideConfidenceIntervalDelta);
+    });
+
+    $('#confidenceIntervalDelta').bind('change', function (event, checkedElement) {
+        hideConfidenceIntervalDelta = checkedElement.textContent == 'Hide';
+        createTable(metrics, runs, shouldIgnoreMemory, referenceIndex, hideConfidenceIntervalDelta);
     });