Changeset 166114 in webkit

Timestamp:

Mar 22, 2014 8:16:42 AM (10 years ago)

Author:

Darin Adler

Message:

ASSERTION FAILED: std::isfinite(num) in WebCore::CSSPrimitiveValue::CSSPrimitiveValue
​https://bugs.webkit.org/show_bug.cgi?id=127361

Source/WebCore:

Huge numbers represented by the 'INF' value can not be used
in CSS rules, so they make the assert fail. We have to make
sure that the parsed property value is finite, otherwise
the property will be dropped.

Test: fast/css/infinite-floating-value.html

Patch by Martin Hodovan <​mhodovan@inf.u-szeged.hu> on 2014-03-22

• css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createValue):

LayoutTests:

Added test shows that CSS rules containing huge numbers
(which are transformed into 'INF' values after parsing)
are dropped.

Patch by Martin Hodovan <​mhodovan@inf.u-szeged.hu> on 2014-03-22
Reviewed by Darin Adler.

• fast/css/infinite-floating-value-expected.txt: Added.
• fast/css/infinite-floating-value.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/infinite-floating-value-expected.txt (added)
• LayoutTests/fast/css/infinite-floating-value.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/CSSValuePool.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-03-22  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
+
+        ASSERTION FAILED: std::isfinite(num) in WebCore::CSSPrimitiveValue::CSSPrimitiveValue
+        https://bugs.webkit.org/show_bug.cgi?id=127361
+
+        Added test shows that CSS rules containing huge numbers
+        (which are transformed into 'INF' values after parsing)
+        are dropped.
+
+        Reviewed by Darin Adler.
+
+        * fast/css/infinite-floating-value-expected.txt: Added.
+        * fast/css/infinite-floating-value.html: Added.
+
 2014-03-21  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-03-22  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
+
+        ASSERTION FAILED: std::isfinite(num) in WebCore::CSSPrimitiveValue::CSSPrimitiveValue
+        https://bugs.webkit.org/show_bug.cgi?id=127361
+
+        Huge numbers represented by the 'INF' value can not be used
+        in CSS rules, so they make the assert fail. We have to make
+        sure that the parsed property value is finite, otherwise
+        the property will be dropped.
+
+        Test: fast/css/infinite-floating-value.html
+
+        * css/CSSValuePool.cpp:
+        (WebCore::CSSValuePool::createValue):
+
 2014-03-21  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/css/CSSValuePool.cpp

@@ -90 +90 @@
 PassRef<CSSPrimitiveValue> CSSValuePool::createValue(double value, CSSPrimitiveValue::UnitTypes type)
 {
+    if (std::isinf(value))
+        return createIdentifierValue(CSSValueID::CSSValueInvalid);
+
     if (value < 0 || value > maximumCacheableIntegerValue)
         return CSSPrimitiveValue::create(value, type);