Changeset 166304 in webkit

Timestamp:

Mar 26, 2014 11:37:44 AM (10 years ago)

Author:

jer.noble@apple.com

Message:

REGRESSION(r162679): Poster image visible under the video
​https://bugs.webkit.org/show_bug.cgi?id=130783

Reviewed by Simon Fraser.

In the listed revision, we started checking for isRenderImage()
instead of isImage(). RenderMedias return 'true' for the first
but 'false' for the second. Change the if() statement to check
for isRenderMedia() in addition to !isRenderImage().

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::isDirectlyCompositedImage):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderLayerBacking.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-03-26  Jer Noble  <jer.noble@apple.com>
+
+        REGRESSION(r162679): Poster image visible under the video
+        https://bugs.webkit.org/show_bug.cgi?id=130783
+
+        Reviewed by Simon Fraser.
+
+        In the listed revision, we started checking for isRenderImage()
+        instead of isImage(). RenderMedias return 'true' for the first
+        but 'false' for the second. Change the if() statement to check
+        for isRenderMedia() in addition to !isRenderImage().
+
+        * rendering/RenderLayerBacking.cpp:
+        (WebCore::RenderLayerBacking::isDirectlyCompositedImage):
+
 2014-03-26  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/rendering/RenderLayerBacking.cpp

@@ -1839 +1839 @@
 bool RenderLayerBacking::isDirectlyCompositedImage() const
 {
-    if (!renderer().isRenderImage() || m_owningLayer.hasBoxDecorationsOrBackground() || renderer().hasClip())
+    if (!renderer().isRenderImage() || renderer().isMedia() || m_owningLayer.hasBoxDecorationsOrBackground() || renderer().hasClip())
         return false;