Changeset 166410 in webkit

Timestamp:

Mar 28, 2014 9:42:02 AM (10 years ago)

Author:

mario.prada@samsung.com

Message:

[GTK] Running minibrowser with url crashes in debug build
​https://bugs.webkit.org/show_bug.cgi?id=130492

Reviewed by Martin Robinson.

Use the ResourceRequest(const URL& url) constructor, instead of the
one taking a String, to call WebPageProxy::loadRequest(), so we
ensure that the passed URI is correctly constructed.

• UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_load_uri): Create an URL out of a SoupURI and
use that to create a ResourceRequest to pass to loadRequest().

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/gtk/WebKitWebView.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-03-28  Mario Sanchez Prada  <mario.prada@samsung.com>
+
+        [GTK] Running minibrowser with url crashes in debug build
+        https://bugs.webkit.org/show_bug.cgi?id=130492
+
+        Reviewed by Martin Robinson.
+
+        Use the ResourceRequest(const URL& url) constructor, instead of the
+        one taking a String, to call WebPageProxy::loadRequest(), so we
+        ensure that the passed URI is correctly constructed.
+
+        * UIProcess/API/gtk/WebKitWebView.cpp:
+        (webkit_web_view_load_uri): Create an URL out of a SoupURI and
+        use that to create a ResourceRequest to pass to loadRequest().
+
 2014-03-27  Pratik Solanki  <psolanki@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp

@@ -2005 +2005 @@
     g_return_if_fail(uri);
 
-    getPage(webView)->loadRequest(String::fromUTF8(uri));
+    GUniquePtr<SoupURI> soupURI(soup_uri_new(uri));
+    getPage(webView)->loadRequest(URL(soupURI.get()));
 }