Changeset 166571 in webkit


Ignore:
Timestamp:
Apr 1, 2014 1:01:26 AM (10 years ago)
Author:
ryuan.choi@samsung.com
Message:

[EFL][WK2] Rename ewk_application_cache_manager_delete{_all}
​https://bugs.webkit.org/show_bug.cgi?id=131012

Reviewed by Gyuyoung Kim.

While discussing Bug 130577, we resulted that _clear and _xxx_del is better name for the EFL.
This patch will rename similar API in ewk_application_cache_manager.

In addition, fixed some typos in doxygen.

  • UIProcess/API/efl/ewk_application_cache_manager.cpp:

(ewk_application_cache_manager_clear): Renamed from ewk_application_cache_manager_delete_all
(ewk_application_cache_manager_entries_for_origin_del): Renamed from ewk_application_cache_manager_delete
(ewk_application_cache_manager_delete_all): Deleted.
(ewk_application_cache_manager_delete): Deleted.

  • UIProcess/API/efl/ewk_application_cache_manager.h:
  • UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:

(TEST_F):

Location:
trunk/Source/WebKit2
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit2/ChangeLog

    r166567 r166571  
     12014-04-01  Ryuan Choi  <ryuan.choi@samsung.com>
     2
     3        [EFL][WK2] Rename ewk_application_cache_manager_delete{_all}
     4        https://bugs.webkit.org/show_bug.cgi?id=131012
     5
     6        Reviewed by Gyuyoung Kim.
     7
     8        While discussing Bug 130577, we resulted that _clear and _xxx_del is better name for the EFL.
     9        This patch will rename similar API in ewk_application_cache_manager.
     10
     11        In addition, fixed some typos in doxygen.
     12
     13        * UIProcess/API/efl/ewk_application_cache_manager.cpp:
     14        (ewk_application_cache_manager_clear): Renamed from ewk_application_cache_manager_delete_all
     15        (ewk_application_cache_manager_entries_for_origin_del): Renamed from ewk_application_cache_manager_delete
     16        (ewk_application_cache_manager_delete_all): Deleted.
     17        (ewk_application_cache_manager_delete): Deleted.
     18        * UIProcess/API/efl/ewk_application_cache_manager.h:
     19        * UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:
     20        (TEST_F):
     21
    1222014-03-31  Zan Dobersek  <zdobersek@igalia.com>
    223

  • trunk/Source/WebKit2/UIProcess/API/efl/ewk_application_cache_manager.cpp

    r165864 r166571  
    7676}
    7777
    78 Eina_Bool ewk_application_cache_manager_delete_all(Ewk_Application_Cache_Manager* manager)
     78Eina_Bool ewk_application_cache_manager_clear(Ewk_Application_Cache_Manager* manager)
    7979{
    8080    EINA_SAFETY_ON_NULL_RETURN_VAL(manager, false);
    … …  
    8585}
    8686
    87 Eina_Bool ewk_application_cache_manager_delete(Ewk_Application_Cache_Manager* manager, Ewk_Security_Origin* origin)
     87Eina_Bool ewk_application_cache_manager_entries_for_origin_del(Ewk_Application_Cache_Manager* manager, Ewk_Security_Origin* origin)
    8888{
    8989    EINA_SAFETY_ON_NULL_RETURN_VAL(manager, false);

  • trunk/Source/WebKit2/UIProcess/API/efl/ewk_application_cache_manager.h

    r165864 r166571  
    6767 * Requests for getting web application cache origins.
    6868 *
    69  * @param context context object
    70  * @param result_callback callback to get web application cache origins
     69 * @param manager Ewk_Application_Cache_Manager object
     70 * @param callback callback to get web application cache origins
    7171 * @param user_data user_data will be passsed when result_callback is called
    7272 *
    7373 * @see Ewk_Application_Cache_Origins_Async_Get_Cb
    7474 */
    75 EAPI void ewk_application_cache_manager_origins_async_get(const Ewk_Application_Cache_Manager *manager, Ewk_Application_Cache_Origins_Async_Get_Cb callback, void *data);
     75EAPI void ewk_application_cache_manager_origins_async_get(const Ewk_Application_Cache_Manager *manager, Ewk_Application_Cache_Origins_Async_Get_Cb callback, void *user_data);
    7676
    7777/**
    78  * Requests for deleting all web application caches.
     78 * Deletes all web application caches.
    7979 *
    80  * @param context context object
     80 * @param manager Ewk_Application_Cache_Manager object
    8181 *
    8282 * @return @c EINA_TRUE on successful request or @c EINA FALSE on failure
    8383 */
    84 EAPI Eina_Bool ewk_application_cache_manager_delete_all(Ewk_Application_Cache_Manager *manager);
     84EAPI Eina_Bool ewk_application_cache_manager_clear(Ewk_Application_Cache_Manager *manager);
    8585
    8686/**
    87  * Requests for deleting web application cache for origin.
     87 * Deletes web application caches for the specified origin.
    8888 *
    89  * @param context context object
    90  * @param origin application cache origin
     89 * @param manager Ewk_Application_Cache_Manager object
     90 * @param origin security origin
    9191 *
    9292 * @return @c EINA_TRUE on successful request or @c EINA_FALSE on failure
    9393 */
    94 EAPI Eina_Bool ewk_application_cache_manager_delete(Ewk_Application_Cache_Manager *manager, Ewk_Security_Origin *origin);
     94EAPI Eina_Bool ewk_application_cache_manager_entries_for_origin_del(Ewk_Application_Cache_Manager *manager, Ewk_Security_Origin *origin);
    9595
    9696#ifdef __cplusplus

  • trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp

    r165959 r166571  
    107107
    108108    // Before testing, remove all caches.
    109     ewk_application_cache_manager_delete_all(data.manager);
     109    ewk_application_cache_manager_clear(data.manager);
    110110
    111111    applicationCacheTimer = ecore_timer_add(0.5, timerCallback, &data);
    … …  
    119119    ASSERT_EQ(1, eina_list_count(data.items));
    120120
    121     ewk_application_cache_manager_delete(data.manager, static_cast<Ewk_Security_Origin*>(eina_list_nth(data.items, 0)));
     121    ewk_application_cache_manager_entries_for_origin_del(data.manager, static_cast<Ewk_Security_Origin*>(eina_list_nth(data.items, 0)));
    122122
    123123    void* origin;
Note: See TracChangeset for help on using the changeset viewer.