Changeset 166711 in webkit

Timestamp:

Apr 3, 2014 2:55:00 AM (10 years ago)

Author:

Manuel Rego Casasnovas

Message:

[webkitpy] perf profiler does not understand --call-graph argument
​https://bugs.webkit.org/show_bug.cgi?id=131132

Reviewed by Ryosuke Niwa.

New versions of perf profiler have changed the argument from --call-graph to -g.

• Scripts/webkitpy/common/system/profiler.py:

(Perf.wrapper_arguments): Use -g instead of --call-graph.

• Scripts/webkitpy/port/driver_unittest.py:

(DriverTest.test_profiler_as_wrapper): Update test accordingly.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/system/profiler.py (modified) (1 diff)
• Scripts/webkitpy/port/driver_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
+
+        [webkitpy] perf profiler does not understand --call-graph argument
+        https://bugs.webkit.org/show_bug.cgi?id=131132
+
+        Reviewed by Ryosuke Niwa.
+
+        New versions of perf profiler have changed the argument from --call-graph to -g.
+
+        * Scripts/webkitpy/common/system/profiler.py:
+        (Perf.wrapper_arguments): Use -g instead of --call-graph.
+        * Scripts/webkitpy/port/driver_unittest.py:
+        (DriverTest.test_profiler_as_wrapper): Update test accordingly.
+
 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
 

trunk/Tools/Scripts/webkitpy/common/system/profiler.py

@@ -149 +149 @@
 
     def wrapper_arguments(self):
-        return [self._perf_path(), "record", "--call-graph", "--output", self._output_path]
+        return [self._perf_path(), "record", "-g", "--output", self._output_path]
 
     def _first_ten_lines_of_profile(self, perf_output):

trunk/Tools/Scripts/webkitpy/port/driver_unittest.py

@@ -102 +102 @@
     def test_profiler_as_wrapper(self):
         driver = Driver(self.make_port(MockSystemHost(os_name='linux'), MockOptions(profile=True, profiler='perf')), None, False)
-        self.assertEqual(driver._command_wrapper(), ['perf', 'record', '--call-graph', '--output', '/mock-build/layout-test-results/test.data'])
+        self.assertEqual(driver._command_wrapper(), ['perf', 'record', '-g', '--output', '/mock-build/layout-test-results/test.data'])
 
     def test_test_to_uri(self):