Changeset 167178 in webkit


Ignore:
Timestamp:
Apr 11, 2014 6:56:06 PM (10 years ago)
Author:
commit-queue@webkit.org
Message:

[WK2] WebProcess crashes, when closing window after opening page by means of context menu
https://bugs.webkit.org/show_bug.cgi?id=131439

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2014-04-11
Reviewed by Tim Horton.

CoordinatedGraphicsLayer calls notifyFlushRequired() through its client when destroyed.
When PageOverlayController::notifyFlushRequired() is called, the DrawingArea could be null
because it's destoryed in WebPage::close().

  • WebProcess/WebPage/PageOverlayController.cpp:

(WebKit::PageOverlayController::notifyFlushRequired): Add null check of m_webPage->drawingArea().

Location:
trunk/Source/WebKit2
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r167177 r167178  
     12014-04-11  Hyowon Kim  <hw1008.kim@samsung.com>
     2
     3        [WK2] WebProcess crashes, when closing window after opening page by means of context menu
     4        https://bugs.webkit.org/show_bug.cgi?id=131439
     5
     6        Reviewed by Tim Horton.
     7
     8        CoordinatedGraphicsLayer calls notifyFlushRequired() through its client when destroyed.
     9        When PageOverlayController::notifyFlushRequired() is called, the DrawingArea could be null
     10        because it's destoryed in WebPage::close().
     11
     12        * WebProcess/WebPage/PageOverlayController.cpp:
     13        (WebKit::PageOverlayController::notifyFlushRequired): Add null check of m_webPage->drawingArea().
     14
    1152014-04-11  Tim Horton  <timothy_horton@apple.com>
    216
  • trunk/Source/WebKit2/WebProcess/WebPage/PageOverlayController.cpp

    r167152 r167178  
    295295void PageOverlayController::notifyFlushRequired(const WebCore::GraphicsLayer*)
    296296{
    297     m_webPage->drawingArea()->scheduleCompositingLayerFlush();
     297    if (m_webPage->drawingArea())
     298        m_webPage->drawingArea()->scheduleCompositingLayerFlush();
    298299}
    299300
Note: See TracChangeset for help on using the changeset viewer.