Changeset 167181 in webkit

Timestamp:

Apr 11, 2014 10:59:34 PM (10 years ago)

Author:

akling@apple.com

Message:

Make NodeList.length inline-cacheable by JSC.
<​https://webkit.org/b/131579>

For objects with custom index or name getters, we have to make sure
that builtin properties take precedence. We do this by scanning the
ancestor chain for a suitable property slot before moving on to
named items.

With this patch, we now mark such builtins as cacheable. This is
safe since the whole point of doing this before processing named
items is to ensure the same slot is returned consistently.

Reviewed by Benjamin Poulain.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorJS.pm (modified) (1 diff)
• bindings/scripts/test/JS/JSTestEventTarget.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-04-11  Andreas Kling  <akling@apple.com>
+
+        Make NodeList.length inline-cacheable by JSC.
+        <https://webkit.org/b/131579>
+
+        For objects with custom index or name getters, we have to make sure
+        that builtin properties take precedence. We do this by scanning the
+        ancestor chain for a suitable property slot before moving on to
+        named items.
+
+        With this patch, we now mark such builtins as cacheable. This is
+        safe since the whole point of doing this before processing named
+        items is to ensure the same slot is returned consistently.
+
+        Reviewed by Benjamin Poulain.
+
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (GenerateGetOwnPropertySlotBody):
+
 2014-04-11  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

@@ -407 +407 @@
             push(@getOwnPropertySlotImpl, "    const ${namespaceMaybe}HashTableValue* entry = getStaticValueSlotEntryWithoutCaching<$className>(exec, propertyName);\n");
             push(@getOwnPropertySlotImpl, "    if (entry) {\n");
-            push(@getOwnPropertySlotImpl, "        slot.setCustom(thisObject, entry->attributes(), entry->propertyGetter());\n");
+            push(@getOwnPropertySlotImpl, "        slot.setCacheableCustom(thisObject, entry->attributes(), entry->propertyGetter());\n");
             push(@getOwnPropertySlotImpl, "        return true;\n");
             push(@getOwnPropertySlotImpl, "    }\n");

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp

@@ -152 +152 @@
     const HashTableValue* entry = getStaticValueSlotEntryWithoutCaching<JSTestEventTarget>(exec, propertyName);
     if (entry) {
-        slot.setCustom(thisObject, entry->attributes(), entry->propertyGetter());
+        slot.setCacheableCustom(thisObject, entry->attributes(), entry->propertyGetter());
         return true;
     }