Changeset 167196 in webkit

Timestamp:

Apr 13, 2014 7:18:48 AM (10 years ago)

Author:

zandobersek@gmail.com

Message:

Remove unnecessary uses of std::move() in return statements
​https://bugs.webkit.org/show_bug.cgi?id=131457

Reviewed by Darin Adler.

Don't use std::move() in return statements unless necessary as it inhibits
named return value optimizations as performed by compilers.

• Modules/battery/BatteryManager.cpp:

(WebCore::BatteryManager::create):

• html/FormController.cpp:

(WebCore::FormController::createSavedFormStateMap):

• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::create):

• platform/RemoteCommandListener.cpp:

(WebCore::RemoteCommandListener::create):

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayer::create):

• platform/ios/RemoteCommandListenerIOS.mm:

(WebCore::RemoteCommandListener::create):

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::GridIterator::nextEmptyGridArea):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setupFilters):

• rendering/style/CounterDirectives.cpp:

(WebCore::clone):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/battery/BatteryManager.cpp (modified) (1 diff)
• html/FormController.cpp (modified) (1 diff)
• html/canvas/WebGLRenderingContext.cpp (modified) (2 diffs)
• platform/RemoteCommandListener.cpp (modified) (1 diff)
• platform/graphics/ca/GraphicsLayerCA.cpp (modified) (1 diff)
• platform/ios/RemoteCommandListenerIOS.mm (modified) (1 diff)
• rendering/RenderGrid.cpp (modified) (1 diff)
• rendering/RenderLayer.cpp (modified) (1 diff)
• rendering/style/CounterDirectives.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-04-13  Zan Dobersek  <zdobersek@igalia.com>
+
+        Remove unnecessary uses of std::move() in return statements
+        https://bugs.webkit.org/show_bug.cgi?id=131457
+
+        Reviewed by Darin Adler.
+
+        Don't use std::move() in return statements unless necessary as it inhibits
+        named return value optimizations as performed by compilers.
+
+        * Modules/battery/BatteryManager.cpp:
+        (WebCore::BatteryManager::create):
+        * html/FormController.cpp:
+        (WebCore::FormController::createSavedFormStateMap):
+        * html/canvas/WebGLRenderingContext.cpp:
+        (WebCore::WebGLRenderingContext::create):
+        * platform/RemoteCommandListener.cpp:
+        (WebCore::RemoteCommandListener::create):
+        * platform/graphics/ca/GraphicsLayerCA.cpp:
+        (WebCore::GraphicsLayer::create):
+        * platform/ios/RemoteCommandListenerIOS.mm:
+        (WebCore::RemoteCommandListener::create):
+        * rendering/RenderGrid.cpp:
+        (WebCore::RenderGrid::GridIterator::nextEmptyGridArea):
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::setupFilters):
+        * rendering/style/CounterDirectives.cpp:
+        (WebCore::clone):
+
 2014-04-13  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/Modules/battery/BatteryManager.cpp

@@ -37 +37 @@
     auto batteryManager = adoptRef(*new BatteryManager(navigator));
     batteryManager.get().suspendIfNeeded();
-    return std::move(batteryManager);
+    return batteryManager;
 }
 

trunk/Source/WebCore/html/FormController.cpp

@@ -408 +408 @@
         formState->appendControlState(control->name(), control->type(), control->saveFormControlState());
     }
-    return std::move(stateMap);
+    return stateMap;
 }
 

trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp

@@ -440 +440 @@
         std::unique_ptr<WebGLRenderingContext> renderingContext(new WebGLRenderingContext(canvas, attributes));
         renderingContext->suspendIfNeeded();
-        return std::move(renderingContext);
+        return renderingContext;
     }
 
@@ -458 +458 @@
     renderingContext->suspendIfNeeded();
 
-    return std::move(renderingContext);
+    return renderingContext;
 }
 

trunk/Source/WebCore/platform/RemoteCommandListener.cpp

@@ -32 +32 @@
 std::unique_ptr<RemoteCommandListener> RemoteCommandListener::create(RemoteCommandListenerClient& client)
 {
-    return std::move(std::unique_ptr<RemoteCommandListener>(new RemoteCommandListener(client)));
+    return std::make_unique<RemoteCommandListener>(client);
 }
 #endif

trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp

@@ -313 +313 @@
     graphicsLayer->initialize();
 
-    return std::move(graphicsLayer);
+    return graphicsLayer;
 }
 

trunk/Source/WebCore/platform/ios/RemoteCommandListenerIOS.mm

@@ -42 +42 @@
 std::unique_ptr<RemoteCommandListener> RemoteCommandListener::create(RemoteCommandListenerClient& client)
 {
-    return std::move(std::unique_ptr<RemoteCommandListener>(new RemoteCommandListenerIOS(client)));
+    return std::unique_ptr<RemoteCommandListener>(new RemoteCommandListenerIOS(client));
 }
 

trunk/Source/WebCore/rendering/RenderGrid.cpp

@@ -131 +131 @@
                 // Advance the iterator to avoid an infinite loop where we would return the same grid area over and over.
                 ++varyingTrackIndex;
-                return std::move(result);
+                return result;
             }
         }

trunk/Source/WebCore/rendering/RenderLayer.cpp

@@ -3968 +3968 @@
         // Note that we will still apply the clipping on the final rendering of the filter.
         paintingInfo.clipToDirtyRect = !filterInfo->renderer()->hasFilterThatMovesPixels();
-        return std::move(filterPainter);
+        return filterPainter;
     }
     return nullptr;

trunk/Source/WebCore/rendering/style/CounterDirectives.cpp

@@ -37 +37 @@
     auto result = std::make_unique<CounterDirectiveMap>();
     *result = counterDirectives;
-    return std::move(result);
+    return result;
 }