Changeset 167281 in webkit

Timestamp:

Apr 14, 2014 5:07:15 PM (10 years ago)

Author:

Bem Jones-Bey

Message:

[CSSExclusions] Remove FIXME referencing closed bug
​https://bugs.webkit.org/show_bug.cgi?id=131645

Reviewed by Dean Jackson.

This is silly, but the comment is really confusing as it's entirely
wrong now.

No new tests, no behavior change.

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresRepaint):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/style/RenderStyle.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-04-14  Bem Jones-Bey  <bjonesbe@adobe.com>
+
+        [CSSExclusions] Remove FIXME referencing closed bug
+        https://bugs.webkit.org/show_bug.cgi?id=131645
+
+        Reviewed by Dean Jackson.
+
+        This is silly, but the comment is really confusing as it's entirely
+        wrong now.
+
+        No new tests, no behavior change.
+
+        * rendering/style/RenderStyle.cpp:
+        (WebCore::RenderStyle::changeRequiresRepaint):
+
 2014-04-14  Andreas Kling  <akling@apple.com>
 

trunk/Source/WebCore/rendering/style/RenderStyle.cpp

@@ -705 +705 @@
 
 #if ENABLE(CSS_SHAPES)
-    // FIXME: The current spec is being reworked to remove dependencies between exclusions and affected 
-    // content. There's a proposal to use floats instead. In that case, wrap-shape should actually relayout 
-    // the parent container. For sure, I will have to revisit this code, but for now I've added this in order 
-    // to avoid having diff() == StyleDifferenceEqual where wrap-shapes actually differ.
-    // Tracking bug: https://bugs.webkit.org/show_bug.cgi?id=62991
     if (rareNonInheritedData->m_shapeOutside != other->rareNonInheritedData->m_shapeOutside)
         return true;