Changeset 167282 in webkit

Timestamp:

Apr 14, 2014 5:14:59 PM (10 years ago)

Author:

jer.noble@apple.com

Message:

[MSE][Mac] video.currentTime is sometimes negative.
​https://bugs.webkit.org/show_bug.cgi?id=131644

Reviewed by Eric Carlson.

AVSampleBufferRenderSynchronizer will occasionally return slightly negative values
when beginning playback. Clamp the return value to 0.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::currentTimeDouble):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-04-14  Jer Noble  <jer.noble@apple.com>
+
+        [MSE][Mac] video.currentTime is sometimes negative.
+        https://bugs.webkit.org/show_bug.cgi?id=131644
+
+        Reviewed by Eric Carlson.
+
+        AVSampleBufferRenderSynchronizer will occasionally return slightly negative values
+        when beginning playback. Clamp the return value to 0.
+
+        * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
+        (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::currentTimeDouble):
+
 2014-04-14  Bem Jones-Bey  <bjonesbe@adobe.com>
 

trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm

@@ -392 +392 @@
 double MediaPlayerPrivateMediaSourceAVFObjC::currentTimeDouble() const
 {
-    return CMTimeGetSeconds(CMTimebaseGetTime([m_synchronizer timebase]));
+    return std::max<double>(0, CMTimeGetSeconds(CMTimebaseGetTime([m_synchronizer timebase])));
 }