Changeset 167406 in webkit

Timestamp:

Apr 16, 2014 5:56:35 PM (10 years ago)

Author:

Brian Burg

Message:

Web Replay: memoize fallback time values for document.lastModified
​https://bugs.webkit.org/show_bug.cgi?id=131318

Reviewed by Joseph Pecoraro.

Source/WebCore:
If a document's Last-Modified header can't be found or used, then
document.lastModified is derived from the current system time or
from filesystem data, which is obviously nondeterministic.

It's better to handle this inside Document::lastModified rather than using
MemoizedDOMResult, because only the fallback case is nondeterministic.

Test: http/tests/inspector/replay/document-last-modified-fallback-value.html

The test is skipped for now, as it will be very flaky without the
functionality introduced by bugs 130728 and 129391.

• dom/Document.cpp:

(WebCore::Document::lastModified): Save or reuse memoized fallback value.

• replay/WebInputs.json: Add input DocumentLastModifiedDate.

LayoutTests:
Mark the new test as skipped until dependent functionality is landed.

• http/tests/inspector/replay/document-last-modified-fallback-value.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/TestExpectations (modified) (1 diff)
• LayoutTests/http/tests/inspector/replay/document-last-modified-fallback-value-expected.txt (added)
• LayoutTests/http/tests/inspector/replay/document-last-modified-fallback-value.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/Document.cpp (modified) (2 diffs)
• Source/WebCore/replay/WebInputs.json (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-04-16  Brian J. Burg  <burg@cs.washington.edu>
+
+        Web Replay: memoize fallback time values for document.lastModified
+        https://bugs.webkit.org/show_bug.cgi?id=131318
+
+        Reviewed by Joseph Pecoraro.
+
+        Mark the new test as skipped until dependent functionality is landed.
+
+        * http/tests/inspector/replay/document-last-modified-fallback-value.html: Added.
+
 2014-04-16  Dean Jackson  <dino@apple.com>
 

trunk/LayoutTests/TestExpectations

@@ -100 +100 @@
 webkit.org/b/131679 inspector/dom/content-flow-list.html [ Skip ]
 webkit.org/b/131679 inspector/dom/content-flow-content-removal.html [ Skip ]
+
+# Doesn't work yet, relies on network replay functionality (webkit.org/b/130728, webkit.org/b/129391)
+webkit.org/b/131318 http/tests/inspector/replay/document-last-modified-fallback-value.html [ Skip ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-04-16  Brian J. Burg  <burg@cs.washington.edu>
+
+        Web Replay: memoize fallback time values for document.lastModified
+        https://bugs.webkit.org/show_bug.cgi?id=131318
+
+        Reviewed by Joseph Pecoraro.
+
+        If a document's Last-Modified header can't be found or used, then 
+        document.lastModified is derived from the current system time or
+        from filesystem data, which is obviously nondeterministic.
+
+        It's better to handle this inside Document::lastModified rather than using
+        MemoizedDOMResult, because only the fallback case is nondeterministic.
+
+        Test: http/tests/inspector/replay/document-last-modified-fallback-value.html
+
+        The test is skipped for now, as it will be very flaky without the
+        functionality introduced by bugs 130728 and 129391.
+
+        * dom/Document.cpp:
+        (WebCore::Document::lastModified): Save or reuse memoized fallback value.
+        * replay/WebInputs.json: Add input DocumentLastModifiedDate.
+
 2014-04-16  David Hyatt  <hyatt@apple.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -221 +221 @@
 
 #if ENABLE(WEB_REPLAY)
+#include "WebReplayInputs.h"
 #include <replay/EmptyInputCursor.h>
 #endif
@@ -3892 +3893 @@
     // specificiation tells us to read the last modification date from the file
     // system.
-    if (!foundDate)
-        date.setMillisecondsSinceEpochForDateTime(currentTimeMS());
+    if (!foundDate) {
+        double fallbackDate = currentTimeMS();
+#if ENABLE(WEB_REPLAY)
+        InputCursor& cursor = inputCursor();
+        if (cursor.isCapturing())
+            cursor.appendInput<DocumentLastModifiedDate>(fallbackDate);
+        else if (cursor.isReplaying()) {
+            if (DocumentLastModifiedDate* input = cursor.fetchInput<DocumentLastModifiedDate>())
+                fallbackDate = input->fallbackValue();
+        }
+#endif
+        date.setMillisecondsSinceEpochForDateTime(fallbackDate);
+    }
+
     return String::format("%02d/%02d/%04d %02d:%02d:%02d", date.month() + 1, date.monthDay(), date.fullYear(), date.hour(), date.minute(), date.second());
 }

trunk/Source/WebCore/replay/WebInputs.json

@@ -166 +166 @@
         },
         {
+            "name": "DocumentLastModifiedDate",
+            "description": "A fallback value used for the document's last modified date if the Last-Modified header can't be found or used.",
+            "queue": "SCRIPT_MEMOIZED",
+            "members": [
+                { "name": "fallbackValue", "type": "double" }
+            ]
+        },
+        {
             "name": "EndSegmentSentinel",
             "description": "A sentinel input to signal the end of a segment.",