Changeset 167588 in webkit


Ignore:
Timestamp:
Apr 21, 2014 12:25:05 AM (10 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, rolling out r167584.
​https://bugs.webkit.org/show_bug.cgi?id=131929

Broke Objective-C bindings test (Requested by ap on #webkit).

Reverted changeset:

"Add Element.matches, the standard name for
webkitMatchesSelector"
​https://bugs.webkit.org/show_bug.cgi?id=131922
​http://trac.webkit.org/changeset/167584

Location:
trunk
Files:
32 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r167585 r167588  
     12014-04-21  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r167584.
     4        https://bugs.webkit.org/show_bug.cgi?id=131929
     5
     6        Broke Objective-C bindings test (Requested by ap on #webkit).
     7
     8        Reverted changeset:
     9
     10        "Add Element.matches, the standard name for
     11        webkitMatchesSelector"
     12        https://bugs.webkit.org/show_bug.cgi?id=131922
     13        http://trac.webkit.org/changeset/167584
     14
    1152014-04-20  Benjamin Poulain  <benjamin@webkit.org>
    216

  • trunk/LayoutTests/fast/dom/SelectorAPI/attrname-case-insensitive-expected.txt

    r167584 r167588  
    11PASS document.querySelector('div[baR]') is document.getElementById('bar')
    2 PASS document.getElementById('bar').matches('div[baR]') is true
    32PASS document.getElementById('bar').webkitMatchesSelector('div[baR]') is true
    43PASS document.querySelector('div[bar]') is document.getElementById('bar')
    5 PASS document.getElementById('bar').matches('div[bar]') is true
    64PASS document.getElementById('bar').webkitMatchesSelector('div[bar]') is true
    75PASS document.querySelector('div[BAR]') is document.getElementById('bar')
    8 PASS document.getElementById('bar').matches('div[BAR]') is true
    96PASS document.getElementById('bar').webkitMatchesSelector('div[BAR]') is true
    107PASS document.querySelector('div[bAR]') is document.getElementById('bar')
    11 PASS document.getElementById('bar').matches('div[bAR]') is true
    128PASS document.getElementById('bar').webkitMatchesSelector('div[bAR]') is true
    139PASS document.querySelector('div[baR="10"]') is document.getElementById('bar')
    14 PASS document.getElementById('bar').matches('div[baR="10"]') is true
    1510PASS document.getElementById('bar').webkitMatchesSelector('div[baR="10"]') is true
    1611PASS document.querySelector('div[bar="10"]') is document.getElementById('bar')
    17 PASS document.getElementById('bar').matches('div[bar="10"]') is true
    1812PASS document.getElementById('bar').webkitMatchesSelector('div[bar="10"]') is true
    1913PASS document.querySelector('div[BAR="10"]') is document.getElementById('bar')
    20 PASS document.getElementById('bar').matches('div[BAR="10"]') is true
    2114PASS document.getElementById('bar').webkitMatchesSelector('div[BAR="10"]') is true
    2215PASS document.querySelector('div[bAR="10"]') is document.getElementById('bar')
    23 PASS document.getElementById('bar').matches('div[bAR="10"]') is true
    2416PASS document.getElementById('bar').webkitMatchesSelector('div[bAR="10"]') is true
    2517PASS document.querySelector('path[pathLength]') is document.getElementById('pa')
    26 PASS document.getElementById('pa').matches('path[pathLength]') is true
    2718PASS document.getElementById('pa').webkitMatchesSelector('path[pathLength]') is true
    2819PASS content.querySelector('path[pathlength]') is null
    2920PASS content.querySelector('path[pathLengTh]') is null
    3021PASS document.querySelector('path[pathLength="200"]') is document.getElementById('pa')
    31 PASS document.getElementById('pa').matches('path[pathLength="200"]') is true
    3222PASS document.getElementById('pa').webkitMatchesSelector('path[pathLength="200"]') is true
    3323PASS content.querySelector('path[pathlength="200"]') is null

  • trunk/LayoutTests/fast/dom/SelectorAPI/attrname-case-insensitive.html

    r167584 r167588  
    1919        function checkMatchingSelector(selector, elementId) {
    2020            shouldBe("document.querySelector('" + selector + "')", "document.getElementById('" + elementId + "')");
    21             shouldBeTrue("document.getElementById('" + elementId + "').matches('" + selector + "')");
    2221            shouldBeTrue("document.getElementById('" + elementId + "').webkitMatchesSelector('" + selector + "')");
    2322        }

  • trunk/LayoutTests/fast/dom/SelectorAPI/attrname-case-sensitive-expected.txt

    r167584 r167588  
    11PASS document.querySelector('div[baR]') is document.getElementById('bar')
    2 PASS document.getElementById('bar').matches('div[baR]') is true
    32PASS document.getElementById('bar').webkitMatchesSelector('div[baR]') is true
    43PASS content.querySelector('div[bar]') is null
    … …  
    65PASS content.querySelector('div[bAR]') is null
    76PASS document.querySelector('div[baR="10"]') is document.getElementById('bar')
    8 PASS document.getElementById('bar').matches('div[baR="10"]') is true
    97PASS document.getElementById('bar').webkitMatchesSelector('div[baR="10"]') is true
    108PASS content.querySelector('div[bar="10"]') is null
    … …  
    1210PASS content.querySelector('div[bAR="10"]') is null
    1311PASS document.querySelector('path[pathLength]') is document.getElementById('pa')
    14 PASS document.getElementById('pa').matches('path[pathLength]') is true
    1512PASS document.getElementById('pa').webkitMatchesSelector('path[pathLength]') is true
    1613PASS content.querySelector('path[pathlength]') is null
    1714PASS content.querySelector('path[pathLengTh]') is null
    1815PASS document.querySelector('path[pathLength="200"]') is document.getElementById('pa')
    19 PASS document.getElementById('pa').matches('path[pathLength="200"]') is true
    2016PASS document.getElementById('pa').webkitMatchesSelector('path[pathLength="200"]') is true
    2117PASS content.querySelector('path[pathlength="200"]') is null

  • trunk/LayoutTests/fast/dom/SelectorAPI/attrname-case-sensitive.xhtml

    r167584 r167588  
    2222        function checkMatchingSelector(selector, elementId) {
    2323            shouldBe("document.querySelector('" + selector + "')", "document.getElementById('" + elementId + "')");
    24             shouldBeTrue("document.getElementById('" + elementId + "').matches('" + selector + "')");
    2524            shouldBeTrue("document.getElementById('" + elementId + "').webkitMatchesSelector('" + selector + "')");
    2625        }

  • trunk/LayoutTests/fast/dom/SelectorAPI/caseID-almost-strict-expected.txt

    r167584 r167588  
    33PASS document.querySelector('#UPPER1').textContent is 'UPPER 1'
    44PASS document.querySelector('#upper2') is null
    5 PASS document.getElementById('lower1').matches('#lower1') is true
    6 PASS document.getElementById('lower2').matches('#LOWER2') is false
    7 PASS document.getElementById('UPPER1').matches('#UPPER1') is true
    8 PASS document.getElementById('UPPER2').matches('#upper2') is false
    95PASS document.getElementById('lower1').webkitMatchesSelector('#lower1') is true
    106PASS document.getElementById('lower2').webkitMatchesSelector('#LOWER2') is false

  • trunk/LayoutTests/fast/dom/SelectorAPI/caseID-almost-strict.html

    r167584 r167588  
    1717        shouldBeNull("document.querySelector('#upper2')");
    1818
    19         shouldBeTrue("document.getElementById('lower1').matches('#lower1')");
    20         shouldBeFalse("document.getElementById('lower2').matches('#LOWER2')");
    21         shouldBeTrue("document.getElementById('UPPER1').matches('#UPPER1')");
    22         shouldBeFalse("document.getElementById('UPPER2').matches('#upper2')");
    2319        shouldBeTrue("document.getElementById('lower1').webkitMatchesSelector('#lower1')");
    2420        shouldBeFalse("document.getElementById('lower2').webkitMatchesSelector('#LOWER2')");

  • trunk/LayoutTests/fast/dom/SelectorAPI/caseID-expected.txt

    r167584 r167588  
    33PASS document.querySelector('#UPPER1').textContent is 'UPPER 1'
    44PASS document.querySelector('#upper2').textContent is 'UPPER 2'
    5 PASS document.getElementById('lower1').matches('#lower1') is true
    6 PASS document.getElementById('lower2').matches('#LOWER2') is true
    7 PASS document.getElementById('UPPER1').matches('#UPPER1') is true
    8 PASS document.getElementById('UPPER2').matches('#upper2') is true
    95PASS document.getElementById('lower1').webkitMatchesSelector('#lower1') is true
    106PASS document.getElementById('lower2').webkitMatchesSelector('#LOWER2') is true

  • trunk/LayoutTests/fast/dom/SelectorAPI/caseID-strict-expected.txt

    r167584 r167588  
    33PASS document.querySelector('#UPPER1').textContent is 'UPPER 1'
    44PASS document.querySelector('#upper2') is null
    5 PASS document.getElementById('lower1').matches('#lower1') is true
    6 PASS document.getElementById('lower2').matches('#LOWER2') is false
    7 PASS document.getElementById('UPPER1').matches('#UPPER1') is true
    8 PASS document.getElementById('UPPER2').matches('#upper2') is false
    95PASS document.getElementById('lower1').webkitMatchesSelector('#lower1') is true
    106PASS document.getElementById('lower2').webkitMatchesSelector('#LOWER2') is false

  • trunk/LayoutTests/fast/dom/SelectorAPI/caseID-strict.html

    r167584 r167588  
    1717        shouldBeNull("document.querySelector('#upper2')");
    1818
    19         shouldBeTrue("document.getElementById('lower1').matches('#lower1')");
    20         shouldBeFalse("document.getElementById('lower2').matches('#LOWER2')");
    21         shouldBeTrue("document.getElementById('UPPER1').matches('#UPPER1')");
    22         shouldBeFalse("document.getElementById('UPPER2').matches('#upper2')");
    2319        shouldBeTrue("document.getElementById('lower1').webkitMatchesSelector('#lower1')");
    2420        shouldBeFalse("document.getElementById('lower2').webkitMatchesSelector('#LOWER2')");

  • trunk/LayoutTests/fast/dom/SelectorAPI/caseID.html

    r167584 r167588  
    1616        shouldBe("document.querySelector('#upper2').textContent", "'UPPER 2'");
    1717
    18         shouldBeTrue("document.getElementById('lower1').matches('#lower1')");
    19         shouldBeTrue("document.getElementById('lower2').matches('#LOWER2')");
    20         shouldBeTrue("document.getElementById('UPPER1').matches('#UPPER1')");
    21         shouldBeTrue("document.getElementById('UPPER2').matches('#upper2')");
    2218        shouldBeTrue("document.getElementById('lower1').webkitMatchesSelector('#lower1')");
    2319        shouldBeTrue("document.getElementById('lower2').webkitMatchesSelector('#LOWER2')");

  • trunk/LayoutTests/fast/dom/SelectorAPI/caseTag-expected.txt

    r167584 r167588  
    11PASS document.querySelector('div SPAN').textContent is 'lower'
    22PASS document.querySelector('div p').textContent is 'UPPER'
    3 PASS document.getElementById('lower1').matches('div SPAN') is true
    4 PASS document.getElementById('UPPER1').matches('div p') is true
    53PASS document.getElementById('lower1').webkitMatchesSelector('div SPAN') is true
    64PASS document.getElementById('UPPER1').webkitMatchesSelector('div p') is true

  • trunk/LayoutTests/fast/dom/SelectorAPI/caseTag.html

    r167584 r167588  
    1212        shouldBe("document.querySelector('div p').textContent", "'UPPER'");
    1313
    14         shouldBeTrue("document.getElementById('lower1').matches('div SPAN')");
    15         shouldBeTrue("document.getElementById('UPPER1').matches('div p')");
    1614        shouldBeTrue("document.getElementById('lower1').webkitMatchesSelector('div SPAN')");
    1715        shouldBeTrue("document.getElementById('UPPER1').webkitMatchesSelector('div p')");

  • trunk/LayoutTests/fast/dom/SelectorAPI/caseTagX-expected.txt

    r167584 r167588  
    11PASS document.querySelector('div SPAN') is null
    2 PASS document.getElementById('lower1').matches('div SPAN') is false
    32PASS document.getElementById('lower1').webkitMatchesSelector('div SPAN') is false
    43PASS successfullyParsed is true

  • trunk/LayoutTests/fast/dom/SelectorAPI/caseTagX.xhtml

    r167584 r167588  
    1616        shouldBeNull("document.querySelector('div SPAN')");
    1717
    18         shouldBeFalse("document.getElementById('lower1').matches('div SPAN')");
    1918        shouldBeFalse("document.getElementById('lower1').webkitMatchesSelector('div SPAN')");
    2019    ]]>

  • trunk/LayoutTests/fast/dom/SelectorAPI/detached-element-expected.txt

    r167584 r167588  
    1212PASS noChild.querySelector('div') is null
    1313PASS noChild.querySelectorAll('div').length is 0
    14 PASS correctNode.matches('div') is true
    15 PASS correctNode.matches('#testId') is true
    1614PASS correctNode.webkitMatchesSelector('div') is true
    1715PASS correctNode.webkitMatchesSelector('#testId') is true

  • trunk/LayoutTests/fast/dom/SelectorAPI/not-supported-namespace-in-selector-expected.txt

    r167584 r167588  
    33PASS: document.querySelector('bbb|pre') throws: Error: NamespaceError: DOM Exception 14
    44PASS: document.querySelectorAll('bbb|pre') throws: Error: NamespaceError: DOM Exception 14
    5 PASS: document.body.matches('bbb|pre') throws: Error: NamespaceError: DOM Exception 14
    65PASS: document.body.webkitMatchesSelector('bbb|pre') throws: Error: NamespaceError: DOM Exception 14
    76PASS: document.querySelector('*|pre') did not throw
    87PASS: document.querySelectorAll('*|pre') did not throw
    9 PASS: document.body.matches('*|pre') did not throw
    108PASS: document.body.webkitMatchesSelector('*|pre') did not throw
    119PASS: document.querySelector('|pre') did not throw
    1210PASS: document.querySelectorAll('|pre') did not throw
    13 PASS: document.body.matches('|pre') did not throw
    1411PASS: document.body.webkitMatchesSelector('|pre') did not throw
    1512PASS: document.querySelector('div bbb|pre') throws: Error: NamespaceError: DOM Exception 14
    1613PASS: document.querySelectorAll('div bbb|pre') throws: Error: NamespaceError: DOM Exception 14
    17 PASS: document.body.matches('div bbb|pre') throws: Error: NamespaceError: DOM Exception 14
    1814PASS: document.body.webkitMatchesSelector('div bbb|pre') throws: Error: NamespaceError: DOM Exception 14
    1915PASS: document.querySelector('div *|pre') did not throw
    2016PASS: document.querySelectorAll('div *|pre') did not throw
    21 PASS: document.body.matches('div *|pre') did not throw
    2217PASS: document.body.webkitMatchesSelector('div *|pre') did not throw
    2318PASS: document.querySelector('div |pre') did not throw
    2419PASS: document.querySelectorAll('div |pre') did not throw
    25 PASS: document.body.matches('div |pre') did not throw
    2620PASS: document.body.webkitMatchesSelector('div |pre') did not throw
    2721PASS: document.querySelector('[bbb|name=value]') throws: Error: NamespaceError: DOM Exception 14
    2822PASS: document.querySelectorAll('[bbb|name=value]') throws: Error: NamespaceError: DOM Exception 14
    29 PASS: document.body.matches('[bbb|name=value]') throws: Error: NamespaceError: DOM Exception 14
    3023PASS: document.body.webkitMatchesSelector('[bbb|name=value]') throws: Error: NamespaceError: DOM Exception 14
    3124PASS: document.querySelector('[*|name=value]') did not throw
    3225PASS: document.querySelectorAll('[*|name=value]') did not throw
    33 PASS: document.body.matches('[*|name=value]') did not throw
    3426PASS: document.body.webkitMatchesSelector('[*|name=value]') did not throw
    3527PASS: document.querySelector('[|name=value]') did not throw
    3628PASS: document.querySelectorAll('[|name=value]') did not throw
    37 PASS: document.body.matches('[|name=value]') did not throw
    3829PASS: document.body.webkitMatchesSelector('[|name=value]') did not throw
    3930PASS: document.querySelector(':-webkit-any(bbb|pre)') throws: Error: NamespaceError: DOM Exception 14
    4031PASS: document.querySelector('div [bbb|name=value]') throws: Error: NamespaceError: DOM Exception 14
    4132PASS: document.querySelectorAll('div [bbb|name=value]') throws: Error: NamespaceError: DOM Exception 14
    42 PASS: document.body.matches('div [bbb|name=value]') throws: Error: NamespaceError: DOM Exception 14
    4333PASS: document.body.webkitMatchesSelector('div [bbb|name=value]') throws: Error: NamespaceError: DOM Exception 14
    4434PASS: document.querySelector('div [*|name=value]') did not throw
    4535PASS: document.querySelectorAll('div [*|name=value]') did not throw
    46 PASS: document.body.matches('div [*|name=value]') did not throw
    4736PASS: document.body.webkitMatchesSelector('div [*|name=value]') did not throw
    4837PASS: document.querySelector('div [|name=value]') did not throw
    4938PASS: document.querySelectorAll('div [|name=value]') did not throw
    50 PASS: document.body.matches('div [|name=value]') did not throw
    5139PASS: document.body.webkitMatchesSelector('div [|name=value]') did not throw
    5240

  • trunk/LayoutTests/fast/dom/SelectorAPI/not-supported-namespace-in-selector.html

    r167584 r167588  
    3434        shouldThrow("document.querySelector('bbb|pre')");
    3535        shouldThrow("document.querySelectorAll('bbb|pre')");
    36         shouldThrow("document.body.matches('bbb|pre')");
    3736        shouldThrow("document.body.webkitMatchesSelector('bbb|pre')");
    3837        shouldNotThrow("document.querySelector('*|pre')");
    3938        shouldNotThrow("document.querySelectorAll('*|pre')");
    40         shouldNotThrow("document.body.matches('*|pre')");
    4139        shouldNotThrow("document.body.webkitMatchesSelector('*|pre')");
    4240        shouldNotThrow("document.querySelector('|pre')");
    4341        shouldNotThrow("document.querySelectorAll('|pre')");
    44         shouldNotThrow("document.body.matches('|pre')");
    4542        shouldNotThrow("document.body.webkitMatchesSelector('|pre')");
    4643
    4744        shouldThrow("document.querySelector('div bbb|pre')");
    4845        shouldThrow("document.querySelectorAll('div bbb|pre')");
    49         shouldThrow("document.body.matches('div bbb|pre')");
    5046        shouldThrow("document.body.webkitMatchesSelector('div bbb|pre')");
    5147        shouldNotThrow("document.querySelector('div *|pre')");
    5248        shouldNotThrow("document.querySelectorAll('div *|pre')");
    53         shouldNotThrow("document.body.matches('div *|pre')");
    5449        shouldNotThrow("document.body.webkitMatchesSelector('div *|pre')");
    5550        shouldNotThrow("document.querySelector('div |pre')");
    5651        shouldNotThrow("document.querySelectorAll('div |pre')");
    57         shouldNotThrow("document.body.matches('div |pre')");
    5852        shouldNotThrow("document.body.webkitMatchesSelector('div |pre')");
    5953
    6054        shouldThrow("document.querySelector('[bbb|name=value]')");
    6155        shouldThrow("document.querySelectorAll('[bbb|name=value]')");
    62         shouldThrow("document.body.matches('[bbb|name=value]')");
    6356        shouldThrow("document.body.webkitMatchesSelector('[bbb|name=value]')");
    6457        shouldNotThrow("document.querySelector('[*|name=value]')");
    6558        shouldNotThrow("document.querySelectorAll('[*|name=value]')");
    66         shouldNotThrow("document.body.matches('[*|name=value]')");
    6759        shouldNotThrow("document.body.webkitMatchesSelector('[*|name=value]')");
    6860        shouldNotThrow("document.querySelector('[|name=value]')");
    6961        shouldNotThrow("document.querySelectorAll('[|name=value]')");
    70         shouldNotThrow("document.body.matches('[|name=value]')");
    7162        shouldNotThrow("document.body.webkitMatchesSelector('[|name=value]')");
    7263
    … …  
    7566        shouldThrow("document.querySelector('div [bbb|name=value]')");
    7667        shouldThrow("document.querySelectorAll('div [bbb|name=value]')");
    77         shouldThrow("document.body.matches('div [bbb|name=value]')");
    7868        shouldThrow("document.body.webkitMatchesSelector('div [bbb|name=value]')");
    7969        shouldNotThrow("document.querySelector('div [*|name=value]')");
    8070        shouldNotThrow("document.querySelectorAll('div [*|name=value]')");
    81         shouldNotThrow("document.body.matches('div [*|name=value]')");
    8271        shouldNotThrow("document.body.webkitMatchesSelector('div [*|name=value]')");
    8372        shouldNotThrow("document.querySelector('div [|name=value]')");
    8473        shouldNotThrow("document.querySelectorAll('div [|name=value]')");
    85         shouldNotThrow("document.body.matches('div [|name=value]')");
    8674        shouldNotThrow("document.body.webkitMatchesSelector('div [|name=value]')");
    8775    }

  • trunk/LayoutTests/fast/dom/SelectorAPI/script-tests/detached-element.js

    r167584 r167588  
    2020shouldBe("noChild.querySelectorAll('div').length", "0");
    2121
    22 shouldBeTrue("correctNode.matches('div')");
    23 shouldBeTrue("correctNode.matches('#testId')");
    2422shouldBeTrue("correctNode.webkitMatchesSelector('div')");
    2523shouldBeTrue("correctNode.webkitMatchesSelector('#testId')");

  • trunk/LayoutTests/fast/dom/SelectorAPI/script-tests/undefined-null-stringify.js

    r167584 r167588  
    1818shouldBe("document.querySelectorAll(undefined).item(0)", "undefinedNode");
    1919
    20 shouldBeTrue("nullNode.matches(null)");
    21 shouldBeTrue("undefinedNode.matches(undefined)");
    2220shouldBeTrue("nullNode.webkitMatchesSelector(null)");
    2321shouldBeTrue("undefinedNode.webkitMatchesSelector(undefined)");

  • trunk/LayoutTests/fast/dom/SelectorAPI/script-tests/viewless-document.js

    r167584 r167588  
    2121shouldBe("testDoc.querySelectorAll('p span').length", "1");
    2222
    23 shouldBeTrue("p1.matches('p')");
    24 shouldBeTrue("s1.matches('p span')");
    25 shouldBeTrue("s2.matches('#s2')");
    26 shouldBeTrue("d1.matches('.d1')");
    2723shouldBeTrue("p1.webkitMatchesSelector('p')");
    2824shouldBeTrue("s1.webkitMatchesSelector('p span')");

  • trunk/LayoutTests/fast/dom/SelectorAPI/undefined-null-stringify-expected.txt

    r167584 r167588  
    1010PASS document.querySelectorAll(undefined).length is 1
    1111PASS document.querySelectorAll(undefined).item(0) is undefinedNode
    12 PASS nullNode.matches(null) is true
    13 PASS undefinedNode.matches(undefined) is true
    1412PASS nullNode.webkitMatchesSelector(null) is true
    1513PASS undefinedNode.webkitMatchesSelector(undefined) is true

  • trunk/LayoutTests/fast/dom/SelectorAPI/viewless-document-expected.txt

    r167584 r167588  
    99PASS testDoc.querySelector('.d1') is d1
    1010PASS testDoc.querySelectorAll('p span').length is 1
    11 PASS p1.matches('p') is true
    12 PASS s1.matches('p span') is true
    13 PASS s2.matches('#s2') is true
    14 PASS d1.matches('.d1') is true
    1511PASS p1.webkitMatchesSelector('p') is true
    1612PASS s1.webkitMatchesSelector('p span') is true

  • trunk/LayoutTests/fast/forms/radio/radio-live-validation-style-expected.txt

    r167584 r167588  
    77PASS backgroundOf($("radio1")) is validColor
    88PASS parent.removeChild($("radio2")); backgroundOf($("radio1")) is invalidColor
    9 PASS $("radio1").remove(); radio2.matches(":valid") is false
    10 PASS radio2.remove(); radio2.matches(":valid") is true
    11 FAIL $("radio1").remove(); radio2.webkitMatchesSelector(":valid") should be false. Threw exception TypeError: null is not an object (evaluating '$("radio1").remove')
     9PASS $("radio1").remove(); radio2.webkitMatchesSelector(":valid") is false
    1210PASS radio2.remove(); radio2.webkitMatchesSelector(":valid") is true
    1311

  • trunk/LayoutTests/fast/forms/radio/radio-live-validation-style.html

    r167584 r167588  
    3535    '<input type=radio name=group1 required id=radio3>';
    3636var radio2 = $('radio2');
    37 shouldBeFalse('$("radio1").remove(); radio2.matches(":valid")');
    38 shouldBeTrue('radio2.remove(); radio2.matches(":valid")');
    3937shouldBeFalse('$("radio1").remove(); radio2.webkitMatchesSelector(":valid")');
    4038shouldBeTrue('radio2.remove(); radio2.webkitMatchesSelector(":valid")');

  • trunk/LayoutTests/fast/harness/results.html

    r167584 r167588  
    274274function matchesSelector(node, selector)
    275275{
    276     if (node.matches)
    277         return node.matches(selector);
    278 
    279276    if (node.webkitMatchesSelector)
    280277        return node.webkitMatchesSelector(selector);

  • trunk/Source/WebCore/ChangeLog

    r167585 r167588  
     12014-04-21  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r167584.
     4        https://bugs.webkit.org/show_bug.cgi?id=131929
     5
     6        Broke Objective-C bindings test (Requested by ap on #webkit).
     7
     8        Reverted changeset:
     9
     10        "Add Element.matches, the standard name for
     11        webkitMatchesSelector"
     12        https://bugs.webkit.org/show_bug.cgi?id=131922
     13        http://trac.webkit.org/changeset/167584
     14
    1152014-04-20  Benjamin Poulain  <benjamin@webkit.org>
    216

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm

    r167584 r167588  
    15601560                $content = "${implementedBy}::" . $codeGenerator->WK_lcfirst($functionName) . "(" . join(", ", @parameterNames) . ")";
    15611561            } else {
    1562                 my $functionImplementationName = $function->signature->extendedAttributes->{"ImplementedAs"} || $codeGenerator->WK_lcfirst($functionName);
    1563                 $content = "$caller->" . $functionImplementationName . "(" . join(", ", @parameterNames) . ")";
     1562                $content = "$caller->" . $codeGenerator->WK_lcfirst($functionName) . "(" . join(", ", @parameterNames) . ")";
    15641563            }
    15651564

  • trunk/Source/WebCore/dom/Element.cpp

    r167584 r167588  
    22972297}
    22982298
    2299 bool Element::matches(const String& selector, ExceptionCode& ec)
     2299bool Element::webkitMatchesSelector(const String& selector, ExceptionCode& ec)
    23002300{
    23012301    SelectorQuery* selectorQuery = document().selectorQueryForString(selector, ec);

  • trunk/Source/WebCore/dom/Element.h

    r167584 r167588  
    457457    virtual bool matchesReadOnlyPseudoClass() const;
    458458    virtual bool matchesReadWritePseudoClass() const;
    459     bool matches(const String& selectors, ExceptionCode&);
     459    bool webkitMatchesSelector(const String& selectors, ExceptionCode&);
    460460    virtual bool shouldAppearIndeterminate() const;
    461461

  • trunk/Source/WebCore/dom/Element.idl

    r167584 r167588  
    108108    [RaisesException] NodeList querySelectorAll(DOMString selectors);
    109109
    110     [RaisesException] boolean matches([Default=Undefined] optional DOMString selectors);
    111     [ImplementedAs=matches, RaisesException] boolean webkitMatchesSelector([Default=Undefined] optional DOMString selectors);
     110    // WebKit extension, pending specification.
     111    [RaisesException] boolean webkitMatchesSelector([Default=Undefined] optional DOMString selectors);
    112112
    113113    // ElementTraversal API

  • trunk/Source/WebCore/inspector/InspectorCSSAgent.cpp

    r167584 r167588  
    11591159        long index = 0;
    11601160        for (const CSSSelector* selector = selectorList.first(); selector; selector = CSSSelectorList::next(selector)) {
    1161             bool matched = element->matches(selector->selectorText(), IGNORE_EXCEPTION);
     1161            bool matched = element->webkitMatchesSelector(selector->selectorText(), IGNORE_EXCEPTION);
    11621162            if (matched)
    11631163                matchingSelectors->addItem(index);
Note: See TracChangeset for help on using the changeset viewer.