Changeset 167663 in webkit

Timestamp:

Apr 22, 2014 9:08:18 AM (10 years ago)

Author:

hyatt@apple.com

Message:

[New Multicolumn] fast/multicol/multicol-with-child-renderLayer-for-input.html puts the textfield in the wrong place
​https://bugs.webkit.org/show_bug.cgi?id=131808

Reviewed by Brady Eidson.

Source/WebCore:

Make sure FrameView is patched to pass in the update pagination flag when subtree layout
is done on textfields. It had code for the old multicolumn system but did not have a check
for the new multicolumn system.

Added fast/multicol/newmulticol/compare-with-old-impl/multicol-with-child-renderLayer-for-input.html

• page/FrameView.cpp:

(WebCore::updateLayerPositionFlags):

LayoutTests:

• fast/multicol/newmulticol/compare-with-old-impl/multicol-with-child-renderLayer-for-input-expected.html: Added.
• fast/multicol/newmulticol/compare-with-old-impl/multicol-with-child-renderLayer-for-input.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/multicol-with-child-renderLayer-for-input-expected.html (added)
• LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/multicol-with-child-renderLayer-for-input.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/FrameView.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-04-22  David Hyatt  <hyatt@apple.com>
+
+        [New Multicolumn] fast/multicol/multicol-with-child-renderLayer-for-input.html puts the textfield in the wrong place
+        https://bugs.webkit.org/show_bug.cgi?id=131808
+
+        Reviewed by Brady Eidson.
+
+        * fast/multicol/newmulticol/compare-with-old-impl/multicol-with-child-renderLayer-for-input-expected.html: Added.
+        * fast/multicol/newmulticol/compare-with-old-impl/multicol-with-child-renderLayer-for-input.html: Added.
+
 2014-04-22  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-04-22  David Hyatt  <hyatt@apple.com>
+
+        [New Multicolumn] fast/multicol/multicol-with-child-renderLayer-for-input.html puts the textfield in the wrong place
+        https://bugs.webkit.org/show_bug.cgi?id=131808
+
+        Reviewed by Brady Eidson.
+    
+        Make sure FrameView is patched to pass in the update pagination flag when subtree layout
+        is done on textfields. It had code for the old multicolumn system but did not have a check
+        for the new multicolumn system.
+
+        Added fast/multicol/newmulticol/compare-with-old-impl/multicol-with-child-renderLayer-for-input.html
+
+        * page/FrameView.cpp:
+        (WebCore::updateLayerPositionFlags):
+
 2014-04-22  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/page/FrameView.cpp

@@ -125 +125 @@
         flags |= RenderLayer::NeedsFullRepaintInBacking;
     }
-    if (isRelayoutingSubtree && layer->isPaginated())
+    if (isRelayoutingSubtree && (layer->isPaginated() || layer->enclosingPaginationLayer()))
         flags |= RenderLayer::UpdatePagination;
     return flags;