Changeset 167675 in webkit


Ignore:
Timestamp:
Apr 22, 2014 12:48:29 PM (10 years ago)
Author:
Manuel Rego Casasnovas
Message:

REGRESSION (r167652): Broke fast/regions/cssom/region-range-for-box-crash.html in debug mode
https://bugs.webkit.org/show_bug.cgi?id=131982

Reviewed by David Hyatt.

Source/WebCore:
The problem was creating the Range from the arguments received at RenderView::setSelection(). Specifically
in this test endPos is 1 when the element has not children which creates an invalid Range.

  • rendering/RenderView.cpp:

(WebCore::RenderView::splitSelectionBetweenSubtrees): Pass 0 as startPos and endPos to Range::create() as we are
not interested in the positions at this point.

LayoutTests:

Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r167672 r167675  
     12014-04-22  Manuel Rego Casasnovas  <rego@igalia.com>
     2
     3        REGRESSION (r167652): Broke fast/regions/cssom/region-range-for-box-crash.html in debug mode
     4        https://bugs.webkit.org/show_bug.cgi?id=131982
     5
     6        Reviewed by David Hyatt.
     7
     8        * TestExpectations: Unskip fast/regions/cssom/region-range-for-box-crash.html.
     9
    1102014-04-22  Brent Fulgham  <bfulgham@apple.com>
    211
  • trunk/LayoutTests/TestExpectations

    r167655 r167675  
    107107# Expando properties on attribute nodes disappear
    108108webkit.org/b/88045 fast/dom/gc-attribute-node.html [ Failure Pass ]
    109 
    110 webkit.org/b/131982 [ Debug ] fast/regions/cssom/region-range-for-box-crash.html [ Crash ]
  • trunk/Source/WebCore/ChangeLog

    r167674 r167675  
     12014-04-22  Manuel Rego Casasnovas  <rego@igalia.com>
     2
     3        REGRESSION (r167652): Broke fast/regions/cssom/region-range-for-box-crash.html in debug mode
     4        https://bugs.webkit.org/show_bug.cgi?id=131982
     5
     6        Reviewed by David Hyatt.
     7
     8        The problem was creating the Range from the arguments received at RenderView::setSelection(). Specifically
     9        in this test endPos is 1 when the element has not children which creates an invalid Range.
     10
     11        * rendering/RenderView.cpp:
     12        (WebCore::RenderView::splitSelectionBetweenSubtrees): Pass 0 as startPos and endPos to Range::create() as we are
     13        not interested in the positions at this point.
     14
    1152014-04-22  Brady Eidson  <beidson@apple.com>
    216
  • trunk/Source/WebCore/rendering/RenderView.cpp

    r167673 r167675  
    800800
    801801    if (start && end) {
    802         RefPtr<Range> initialRange = Range::create(document(), start->node(), startPos, end->node(), endPos);
     802        RefPtr<Range> initialRange = Range::create(document(), start->node(), 0, end->node(), 0);
    803803
    804804        Node* startNode = initialRange->startContainer();
Note: See TracChangeset for help on using the changeset viewer.