Changeset 167678 in webkit

Timestamp:

Apr 22, 2014 1:31:47 PM (10 years ago)

Author:

hyatt@apple.com

Message:

[New Multicolumn] widows/orphans cause assertion failures.
​https://bugs.webkit.org/show_bug.cgi?id=131233

Reviewed by Dean Jackson.

• rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::recordSpaceShortage):
Fix an obvious bug where the space shortage is recorded twice (and the
if statement that kept it from being negative is accidentally ignored).

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderMultiColumnSet.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-04-22  David Hyatt  <hyatt@apple.com>
+
+        [New Multicolumn] widows/orphans cause assertion failures.
+        https://bugs.webkit.org/show_bug.cgi?id=131233
+
+        Reviewed by Dean Jackson.
+
+        * rendering/RenderMultiColumnSet.cpp:
+        (WebCore::RenderMultiColumnSet::recordSpaceShortage):
+        Fix an obvious bug where the space shortage is recorded twice (and the
+        if statement that kept it from being negative is accidentally ignored).
+
 2014-04-22  David Hyatt  <hyatt@apple.com>
 

trunk/Source/WebCore/rendering/RenderMultiColumnSet.cpp

@@ -302 +302 @@
     if (spaceShortage > 0)
         m_minSpaceShortage = spaceShortage;
-
-    m_minSpaceShortage = spaceShortage;
 }