Changeset 167702 in webkit

Timestamp:

Apr 23, 2014 2:39:51 AM (10 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] run-webkit-tests script is failing to invoke run-launcher
​https://bugs.webkit.org/show_bug.cgi?id=132051

Patch by Lorenzo Tilve <​ltilve@igalia.com> on 2014-04-23
Reviewed by Philippe Normand.

After the WK1 support was dropped, if run-webkit-tests is executed
without --no-show-results parameter, the launcher is being called
using a -2 parameter that is it causing the run-launcher to break.

• Scripts/webkitpy/port/gtk.py:

(GtkPort.show_results_html_file):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/gtk.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
+
+        [GTK] run-webkit-tests script is failing to invoke run-launcher
+        https://bugs.webkit.org/show_bug.cgi?id=132051
+
+        Reviewed by Philippe Normand.
+
+        After the WK1 support was dropped, if run-webkit-tests is executed
+        without --no-show-results parameter, the launcher is being called
+        using a -2 parameter that is it causing the run-launcher to break.
+
+        * Scripts/webkitpy/port/gtk.py:
+        (GtkPort.show_results_html_file):
+
 2014-04-22  Tim Horton  <timothy_horton@apple.com>
 

trunk/Tools/Scripts/webkitpy/port/gtk.py

@@ -185 +185 @@
     def show_results_html_file(self, results_filename):
         run_launcher_args = ["file://%s" % results_filename]
-        if self.get_option('webkit_test_runner'):
-            run_launcher_args.append('-2')
         # FIXME: old-run-webkit-tests also added ["-graphicssystem", "raster", "-style", "windows"]
         # FIXME: old-run-webkit-tests converted results_filename path for cygwin.